Skip to content

[core] pnpm migration #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 100 commits into from
Jun 21, 2025
Merged

[core] pnpm migration #1594

merged 100 commits into from
Jun 21, 2025

Conversation

mattpodwysocki
Copy link
Collaborator

This is a refactoring to introduce the following:

  • Refactor the internal core to @genaiscript/core
  • Refactor the CLI internals to @genaiscript/runtime
  • Migrate to use tshy for builds for both CommonJS and ESM
  • Migrate to use vitest for testing

@pelikhan
Copy link
Member

  • if you could update dev.mdx in the docs with the new build instructions.
  • I tried pnpm install then pnpm build on a new codespace, but it seemed to enter in a infinite codeloop.

@pelikhan pelikhan changed the base branch from dev to dev-pretty June 19, 2025 05:00
@pelikhan pelikhan changed the base branch from dev-pretty to dev June 19, 2025 05:00
@pelikhan
Copy link
Member

maybe add a new workflow file that runs the new build/tests?

@dsyme
Copy link

dsyme commented Jun 19, 2025

@mattpodwysocki Love this work! Would be great to have it in - @pelikhan tells me it solves many of the things I've been asking for 😄

@pelikhan pelikhan marked this pull request as ready for review June 20, 2025 23:35
Copy link
Contributor

Investigator report

Context collection

  • run id: 15789962549
  • failed job
  • last successful run not found

AI Analysis

AI-generated content by gai may be incorrect. Use reactions to eval.

@pelikhan pelikhan self-requested a review June 21, 2025 01:48
Copy link
Contributor

Linter: variable-names

No test cases found for the newly added .editorconfig file. Add relevant test cases to validate its configurations.

Linter: stats

Here are some basic stats on the provided diff:

Stat Count
Deleted Lines 171
Added Lines 8
Files Modified 19
Files Added 1

Linter: no-fix-mes

No "FIXME" comments detected, all good here.

Linter: grumpy-dev

  1. Why is there no .editorconfig file description? Back in my day, we explained our changes to future contributors, especially significant ones like configuration files.
  2. These removed yarn commands look like a mess that might cause build problems. Removing critical commands like caching or compilation without explanation? A surefire way to ruin someone's day.
  3. So, you decided to modify 19 workflow files at once? That's either confidence or recklessness. Testing this properly is going to be a nightmare.
  4. No meaningful comments on why so many lines were removed. Amateurs...
  5. If this is an "improvement," where’s the documentation or reference for why these changes are better?

Linter: diagrams

Here’s a summary of the workflow changes in diagram format:

Loading
graph LR
    subgraph ".github/workflows"
        old[Old Steps]
        new[Updated Steps]
        
        old -->|Files Modified| anthropic.yml
        old -->|Files Modified| azure.yml
        old -->|Files Modified| build-genai-commit.yml
        old -->|Files Modified| build-genai.yml
        old -->|Files Modified| build.yml
        old -->|Files Modified| cli-test.yml
        old -->|Files Modified| docs.yml
        old -->|Files Modified| genai-azure-service-principal.yml
        old -->|Files Modified| genai-blog-post.yml
        old -->|Files Modified| genai-commander.yml
        old -->|Files Modified| genai-commit-tests.yml
        old -->|Files Modified| genai-docs.yml
        old -->|Files Modified| genai-iat.yml
        old -->|Files Modified| genai-investigator.yml
        old -->|Files Modified| genai-issue-bot.yml
        old -->|Files Modified| genai-issue-review.yml
        old -->|Files Modified| genai-linters.yml
        old -->|Files Modified| genai-pr-commit-review.yml
        old -->|Files Modified| genai-pr-docs-commit-review.yml
        new[.editorconfig Added]
    end

Linter: description

The description of the intended purpose of these changes is missing or unclear. Provide a clear justification for:

  1. Addition of .editorconfig.
  2. Removal of yarn commands and apparent downsizing of GitHub Actions workflows.

Linter: comments

  1. Missing inline comments for the newly added .editorconfig file. Explain key settings or reasoning.
  2. No explanation for workflow simplifications. Add comments to clarify what has been removed and why.

AI-generated content by linters may be incorrect. Use reactions to eval.

pelikhan added 2 commits June 21, 2025 01:52
- Updated package.json scripts to use pnpm instead of yarn for genai commands.
- Modified README updater documentation to reflect the change from yarn to pnpm.
- Changed comments in show_n_tell.genai.mjs to use pnpm commands.
- Updated vscode package.json to use pnpm for prepublish script.
- Removed force install script from slides package.json.
@pelikhan pelikhan merged commit 50b6feb into dev Jun 21, 2025
11 of 14 checks passed
@pelikhan pelikhan deleted the feat/pnpm-migration branch June 21, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants