Try to send inline from DpRawTxEnqueue #2835
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On our lola VMs, it seems to improve latency by a bit when response sizes are small. I used |
|
Not much improvement regarding latency but throughput seems to be noticeably improved. |
nibanks
reviewed
Jun 22, 2022
nibanks
reviewed
Jun 22, 2022
nibanks
reviewed
Jun 22, 2022
nibanks
reviewed
Jun 23, 2022
nibanks
reviewed
Jun 23, 2022
nibanks
reviewed
Jun 24, 2022
nibanks
reviewed
Jun 24, 2022
nibanks
reviewed
Jun 24, 2022
Comment on lines
+1564
to
+1565
| // worker TX queue (used to actually send packets), but only if we don't | ||
| // already have anything in the worker TX queue (why?). |
There was a problem hiding this comment.
@mtfriesen I believe you wrote the original logic (which we are just moving here), so could you answer the "why?" part? Why do we only move the TxQueue to the WorkerTxQueue if the WorkerTxQueue is currently empty?
nibanks
reviewed
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In CxPlatDpRawTxEnqueue, if we are enqueuing a TX packet onto a queue that's polled by the same thread, try to do send the packet inline if it has FIN bit set.
Testing
CI
Documentation
N/A