Skip to content

Kernel Platform Worker Support #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

Conversation

nibanks
Copy link
Collaborator

@nibanks nibanks commented Oct 9, 2024

Description

Extracts/refactors some of the code in #4023 to support platform worker threads, which is a prereq for kernel xdp support.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner October 9, 2024 13:28
@nibanks nibanks added OS: Windows (Kernel) Area: Core Related to the shared, core protocol logic labels Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.00%. Comparing base (2e4a9f0) to head (a458629).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/core/worker.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4605      +/-   ##
==========================================
- Coverage   87.45%   87.00%   -0.45%     
==========================================
  Files          59       59              
  Lines       18048    18061      +13     
==========================================
- Hits        15783    15714      -69     
- Misses       2265     2347      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nibanks
Copy link
Collaborator Author

nibanks commented Oct 9, 2024

Looks like the kernel BVTs are crashing. I will try to investigate later.

nigriMSFT
nigriMSFT previously approved these changes Oct 11, 2024
ami-GS
ami-GS previously approved these changes Nov 14, 2024
@nibanks
Copy link
Collaborator Author

nibanks commented Nov 14, 2024

Something seems broken in netperf runs. I can't tell if it's because of this or not. Needs to be investigated before merging.

@ami-GS
Copy link
Contributor

ami-GS commented Nov 15, 2024

Is the netperf result reliable? wsk related failure is really few. others are more

@nibanks nibanks marked this pull request as draft November 21, 2024 15:12
@nibanks
Copy link
Collaborator Author

nibanks commented Nov 21, 2024

Converted this back to draft, because we need to switch to using NtCreateIoCompletion, NtSetIoCompletion, and NtRemoveIoCompletionEx.

@mtfriesen
Copy link
Contributor

Converted this back to draft, because we need to switch to using NtCreateIoCompletion, NtSetIoCompletion, and NtRemoveIoCompletionEx.

I suggest using the Zw variants for KM, unless QUIC is calling on behalf of the user mode thread calling QUIC, and all in the same thread context.

Co-authored-by: Nick Banks <nibanks@microsoft.com>
@nibanks nibanks marked this pull request as ready for review February 13, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Related to the shared, core protocol logic OS: Windows (Kernel)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants