Skip to content

fix(epoll): buffer overflow when GSO off #4717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/2.3
Choose a base branch
from
Open

fix(epoll): buffer overflow when GSO off #4717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(epoll): buffer overflow when GSO off
  • Loading branch information
@qzhuyan
qzhuyan committed Dec 19, 2024
commit 9261dacc1dd9a67f6fa8d5fbe663082508b4c605
3 changes: 2 additions & 1 deletion src/platform/datapath_epoll.c
View file
Original file line number Diff line number Diff line change
@@ -2154,7 +2154,8 @@ CxPlatSendDataFinalizeSendBuffer(
struct iovec* IoVec = &SendData->Iovs[SendData->BufferCount - 1];
IoVec->iov_base = SendData->ClientBuffer.Buffer;
IoVec->iov_len = SendData->ClientBuffer.Length;
if (SendData->TotalSize + SendData->SegmentSize > sizeof(SendData->Buffer) ||
if (SendData->SegmentSize == 0 ||
SendData->TotalSize + SendData->SegmentSize > sizeof(SendData->Buffer) ||
SendData->BufferCount == SendData->SocketContext->DatapathPartition->Datapath->SendIoVecCount) {
SendData->ClientBuffer.Buffer = NULL;
} else {
Loading
Oops, something went wrong.