Skip to content

Only One Send or Recevie Flush per Connection Drain #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nibanks
Copy link
Collaborator

@nibanks nibanks commented May 12, 2025

Description

Updates the connection operation draining logic to only flush send and receive once we call, instead of over and over. The goal here is to improve fairness between connections when they are CPU limited (i.e. both sending or receiving a lot).

Testing

CI/CD

Documentation

N/A

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.02%. Comparing base (a9504fe) to head (319ef1b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5097      +/-   ##
==========================================
- Coverage   87.36%   86.02%   -1.35%     
==========================================
  Files          59       59              
  Lines       18035    18043       +8     
==========================================
- Hits        15756    15521     -235     
- Misses       2279     2522     +243     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -7823,6 +7825,15 @@ QuicConnDrainOperations(
QuicPerfCounterIncrement(Connection->Partition, QUIC_PERF_COUNTER_CONN_OPER_COMPLETED);
}

if (MoreFlushRecvOper) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether this can have negative impact on this connection throughput? Because I think this operation will be dequeued and processed on next schedule for this connection in worker loop, which might introduce some delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants