Fix the AckSendDelay test #5125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
AckSendDelay
test was flaky and of doubtful utility:it asserts there was only a single ACK received after a client send a buffer, which isn't fully true: other frames can be sent for reasons outside of the test control (for instance, NEW_CONNECTION_ID).
the ack delay feature tested is more about whether an ACK is eventually sent if no other ack-eliciting frame is received, and less about whether an ack piggy-pack on the next frame sent by the server (which is an MsQuic implementation detail)
The test is re-written to validate an ACK is received within a reasonable amount of time after a send.
Testing
N/A
Documentation
N/A