Add Writability to Storage Abstraction #5133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5133 +/- ##
==========================================
+ Coverage 86.05% 86.84% +0.78%
==========================================
Files 59 59
Lines 18048 18086 +38
==========================================
+ Hits 15532 15707 +175
+ Misses 2516 2379 -137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nibanks
reviewed
May 31, 2025
guhetier
reviewed
Jun 2, 2025
guhetier
reviewed
Jun 2, 2025
guhetier
reviewed
Jun 2, 2025
guhetier
reviewed
Jun 2, 2025
guhetier
reviewed
Jun 2, 2025
guhetier
reviewed
Jun 2, 2025
guhetier
reviewed
Jun 2, 2025
guhetier
reviewed
Jun 2, 2025
anrossi
commented
Jun 3, 2025
guhetier
reviewed
Jun 9, 2025
guhetier
reviewed
Jun 9, 2025
guhetier
reviewed
Jun 9, 2025
guhetier
reviewed
Jun 9, 2025
guhetier
reviewed
Jun 9, 2025
guhetier
reviewed
Jun 9, 2025
guhetier
reviewed
Jun 10, 2025
Co-authored-by: Guillaume Hetier <guhetier@microsoft.com>
Co-authored-by: Guillaume Hetier <guhetier@microsoft.com>
guhetier
reviewed
Jun 12, 2025
guhetier
reviewed
Jun 12, 2025
guhetier
previously approved these changes
Jun 12, 2025
guhetier
approved these changes
Jun 13, 2025
anrossi
added a commit
that referenced
this pull request
Jun 13, 2025
* Add Writability to Storage Abstraction * Add tests from #5132 --------- Co-authored-by: Guillaume Hetier <guhetier@microsoft.com>
anrossi
added a commit
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For testing purposes, having the ability to use the platform abstraction to write to the settings storage would be beneficial. This change adds the ability to open the storage with a writable flag, allowing for testing of the storage interface without having to duplicate the storage abstraction into test code.
Testing
Added new Settings test that uses the Storage API.
Updated existing API test to use new Storage API instead of direct registry calls.
Documentation
No documentation change as this is an internal implementation detail.