Skip to content

Implement packet number skipping for attack detection and improve security #5146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 7, 2025

Conversation

nibanks
Copy link
Collaborator

@nibanks nibanks commented Jun 6, 2025

Description

Randomizes the initial packet number used and periodically (randomly) skips packet numbers.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner June 6, 2025 17:23
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.95%. Comparing base (2e4a9f0) to head (a97be43).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/core/loss_detection.c 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5146      +/-   ##
==========================================
- Coverage   87.45%   86.95%   -0.50%     
==========================================
  Files          59       59              
  Lines       18048    18061      +13     
==========================================
- Hits        15783    15705      -78     
- Misses       2265     2356      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nibanks nibanks added Area: Security Related to security or quality testing Area: Core Related to the shared, core protocol logic labels Jun 7, 2025
@nibanks nibanks merged commit d46ad00 into main Jun 7, 2025
437 of 439 checks passed
@nibanks nibanks deleted the skip-packets branch June 7, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Related to the shared, core protocol logic Area: Security Related to security or quality testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants