Skip to content

Add Kernel Static Assert Correct Version is Targetted #5147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025

Conversation

nibanks
Copy link
Collaborator

@nibanks nibanks commented Jun 7, 2025

Description

This adds a static assert to the kernel header to ensure we're targetting the right downlevel release (Fe). Otherwise, it can break back-compat.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner June 7, 2025 14:43
@nibanks nibanks enabled auto-merge (squash) June 7, 2025 14:46
Copy link

codecov bot commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.76%. Comparing base (2e4a9f0) to head (a1b5fb9).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5147      +/-   ##
==========================================
- Coverage   87.45%   86.76%   -0.69%     
==========================================
  Files          59       59              
  Lines       18048    18061      +13     
==========================================
- Hits        15783    15670     -113     
- Misses       2265     2391     +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@guhetier guhetier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nibanks nibanks merged commit f9a446e into main Jun 7, 2025
435 of 438 checks passed
@nibanks nibanks deleted the kernel-build-assert branch June 7, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants