Update bindgen requirement from 0.71 to 0.72 #5172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [bindgen](https://github.com/rust-lang/rust-bindgen) to permit the latest version. - [Release notes](https://github.com/rust-lang/rust-bindgen/releases) - [Changelog](https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md) - [Commits](rust-lang/rust-bindgen@v0.71.0...v0.72.0) --- updated-dependencies: - dependency-name: bindgen dependency-version: 0.72.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
dependabot
bot
added
dependencies
Cargo - windows-latestThe rust bindings need to be updated. Please apply ( diff --git a/src/rs/ffi/win_bindings.rs b/src/rs/ffi/win_bindings.rs
index 63decb4..6e3c54a 100644
--- a/src/rs/ffi/win_bindings.rs
+++ b/src/rs/ffi/win_bindings.rs
@@ -1,4 +1,4 @@
-/* automatically generated by rust-bindgen 0.71.1 */
+/* automatically generated by rust-bindgen 0.72.0 */
#[repr(C)]
#[derive(Copy, Clone, Debug, Default, Eq, Hash, Ord, PartialEq, PartialOrd)]
@@ -36,7 +36,9 @@ where
pub unsafe fn raw_get_bit(this: *const Self, index: usize) -> bool {
debug_assert!(index / 8 < core::mem::size_of::<Storage>());
let byte_index = index / 8;
- let byte = *(core::ptr::addr_of!((*this).storage) as *const u8).offset(byte_index as isize);
+ let byte = unsafe {
+ *(core::ptr::addr_of!((*this).storage) as *const u8).offset(byte_index as isize)
+ };
Self::extract_bit(byte, index)
}
#[inline]
@@ -47,11 +49,7 @@ where
index % 8
};
let mask = 1 << bit_index;
- if val {
- byte | mask
- } else {
- byte & !mask
- }
+ if val { byte | mask } else { byte & !mask }
}
#[inline]
pub fn set_bit(&mut self, index: usize, val: bool) {
@@ -64,9 +62,10 @@ where
pub unsafe fn raw_set_bit(this: *mut Self, index: usize, val: bool) {
debug_assert!(index / 8 < core::mem::size_of::<Storage>());
let byte_index = index / 8;
- let byte =
- (core::ptr::addr_of_mut!((*this).storage) as *mut u8).offset(byte_index as isize);
- *byte = Self::change_bit(*byte, index, val);
+ let byte = unsafe {
+ (core::ptr::addr_of_mut!((*this).storage) as *mut u8).offset(byte_index as isize)
+ };
+ unsafe { *byte = Self::change_bit(*byte, index, val) };
}
#[inline]
pub fn get(&self, bit_offset: usize, bit_width: u8) -> u64 {
@@ -93,7 +92,7 @@ where
debug_assert!((bit_offset + (bit_width as usize)) / 8 <= core::mem::size_of::<Storage>());
let mut val = 0;
for i in 0..(bit_width as usize) {
- if Self::raw_get_bit(this, i + bit_offset) {
+ if unsafe { Self::raw_get_bit(this, i + bit_offset) } {
let index = if cfg!(target_endian = "big") {
bit_width as usize - 1 - i
} else {
@@ -133,7 +132,7 @@ where
} else {
i
};
- Self::raw_set_bit(this, index + bit_offset, val_bit_is_set);
+ unsafe { Self::raw_set_bit(this, index + bit_offset, val_bit_is_set) };
}
}
}
@@ -5734,7 +5733,11 @@ const _: () = {
[::std::mem::size_of::<QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14>() - 16usize];
["Alignment of QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14"]
[::std::mem::align_of::<QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14>() - 8usize];
- ["Offset of field: QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14::ResumptionStateLength"] [:: std :: mem :: offset_of ! (QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14 , ResumptionStateLength) - 0usize] ;
+ ["Offset of field: QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14::ResumptionStateLength"]
+ [::std::mem::offset_of!(
+ QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14,
+ ResumptionStateLength
+ ) - 0usize];
["Offset of field: QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14::ResumptionState"][::std::mem::offset_of!(
QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14,
ResumptionState
@@ -5753,7 +5756,11 @@ const _: () = {
[::std::mem::size_of::<QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15>() - 16usize];
["Alignment of QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15"]
[::std::mem::align_of::<QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15>() - 8usize];
- ["Offset of field: QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15::ResumptionTicketLength"] [:: std :: mem :: offset_of ! (QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15 , ResumptionTicketLength) - 0usize] ;
+ ["Offset of field: QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15::ResumptionTicketLength"]
+ [::std::mem::offset_of!(
+ QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15,
+ ResumptionTicketLength
+ ) - 0usize];
["Offset of field: QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15::ResumptionTicket"][::std::mem::offset_of!(
QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15,
ResumptionTicket |
Cargo - ubuntu-latestThe rust bindings need to be updated. Please apply ( diff --git a/src/rs/ffi/linux_bindings.rs b/src/rs/ffi/linux_bindings.rs
index cf4039b..a6dcd0f 100644
--- a/src/rs/ffi/linux_bindings.rs
+++ b/src/rs/ffi/linux_bindings.rs
@@ -1,4 +1,4 @@
-/* automatically generated by rust-bindgen 0.71.1 */
+/* automatically generated by rust-bindgen 0.72.0 */
#[repr(C)]
#[derive(Copy, Clone, Debug, Default, Eq, Hash, Ord, PartialEq, PartialOrd)]
@@ -36,7 +36,9 @@ where
pub unsafe fn raw_get_bit(this: *const Self, index: usize) -> bool {
debug_assert!(index / 8 < core::mem::size_of::<Storage>());
let byte_index = index / 8;
- let byte = *(core::ptr::addr_of!((*this).storage) as *const u8).offset(byte_index as isize);
+ let byte = unsafe {
+ *(core::ptr::addr_of!((*this).storage) as *const u8).offset(byte_index as isize)
+ };
Self::extract_bit(byte, index)
}
#[inline]
@@ -47,11 +49,7 @@ where
index % 8
};
let mask = 1 << bit_index;
- if val {
- byte | mask
- } else {
- byte & !mask
- }
+ if val { byte | mask } else { byte & !mask }
}
#[inline]
pub fn set_bit(&mut self, index: usize, val: bool) {
@@ -64,9 +62,10 @@ where
pub unsafe fn raw_set_bit(this: *mut Self, index: usize, val: bool) {
debug_assert!(index / 8 < core::mem::size_of::<Storage>());
let byte_index = index / 8;
- let byte =
- (core::ptr::addr_of_mut!((*this).storage) as *mut u8).offset(byte_index as isize);
- *byte = Self::change_bit(*byte, index, val);
+ let byte = unsafe {
+ (core::ptr::addr_of_mut!((*this).storage) as *mut u8).offset(byte_index as isize)
+ };
+ unsafe { *byte = Self::change_bit(*byte, index, val) };
}
#[inline]
pub fn get(&self, bit_offset: usize, bit_width: u8) -> u64 {
@@ -93,7 +92,7 @@ where
debug_assert!((bit_offset + (bit_width as usize)) / 8 <= core::mem::size_of::<Storage>());
let mut val = 0;
for i in 0..(bit_width as usize) {
- if Self::raw_get_bit(this, i + bit_offset) {
+ if unsafe { Self::raw_get_bit(this, i + bit_offset) } {
let index = if cfg!(target_endian = "big") {
bit_width as usize - 1 - i
} else {
@@ -133,7 +132,7 @@ where
} else {
i
};
- Self::raw_set_bit(this, index + bit_offset, val_bit_is_set);
+ unsafe { Self::raw_set_bit(this, index + bit_offset, val_bit_is_set) };
}
}
}
@@ -5704,7 +5703,11 @@ const _: () = {
[::std::mem::size_of::<QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14>() - 16usize];
["Alignment of QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14"]
[::std::mem::align_of::<QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14>() - 8usize];
- ["Offset of field: QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14::ResumptionStateLength"] [:: std :: mem :: offset_of ! (QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14 , ResumptionStateLength) - 0usize] ;
+ ["Offset of field: QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14::ResumptionStateLength"]
+ [::std::mem::offset_of!(
+ QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14,
+ ResumptionStateLength
+ ) - 0usize];
["Offset of field: QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14::ResumptionState"][::std::mem::offset_of!(
QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_14,
ResumptionState
@@ -5723,7 +5726,11 @@ const _: () = {
[::std::mem::size_of::<QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15>() - 16usize];
["Alignment of QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15"]
[::std::mem::align_of::<QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15>() - 8usize];
- ["Offset of field: QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15::ResumptionTicketLength"] [:: std :: mem :: offset_of ! (QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15 , ResumptionTicketLength) - 0usize] ;
+ ["Offset of field: QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15::ResumptionTicketLength"]
+ [::std::mem::offset_of!(
+ QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15,
+ ResumptionTicketLength
+ ) - 0usize];
["Offset of field: QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15::ResumptionTicket"][::std::mem::offset_of!(
QUIC_CONNECTION_EVENT__bindgen_ty_1__bindgen_ty_15,
ResumptionTicket |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5172 +/- ##
==========================================
- Coverage 86.57% 86.11% -0.47%
==========================================
Files 59 59
Lines 18086 18086
==========================================
- Hits 15658 15574 -84
- Misses 2428 2512 +84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anrossi
approved these changes
Jun 20, 2025
csujedihy
approved these changes
Jun 20, 2025
guhetier
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on bindgen to permit the latest version.
Release notes
Sourced from bindgen's releases.
Changelog
Sourced from bindgen's changelog.
... (truncated)
Commits
d0e7d6bchore: Releasee7f0b9dUpdate changelog.2882af2Refactor item_name method to use ItemInfo structe2940cdchore: Fix some warnings with latest stable.5d7f684codegen: Avoid crashing on variadic unions without layout information.2613129Remove unused which-rustfmt featurefef1561Fix rustfmt errors965a13cAdd testb9c6984Use callbacks properly803d73eUse parse_callbacks from optionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)