Skip to content

Fix quictls static assert #5179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Fix quictls static assert #5179

merged 1 commit into from
Jun 20, 2025

Conversation

anrossi
Copy link
Contributor

@anrossi anrossi commented Jun 20, 2025

Description

The latest version of MSVC supplies a warning on these static asserts which guarantee interoperability of certain enumerated types. This former cast-to-int approach was no longer working. This now uses a cast to the MsQuic enumerated type.

Testing

CI

Documentation

No documentation change needed.

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (31d2b73) to head (ff07b53).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5179      +/-   ##
==========================================
- Coverage   87.19%   86.88%   -0.31%     
==========================================
  Files          59       59              
  Lines       18086    18086              
==========================================
- Hits        15770    15714      -56     
- Misses       2316     2372      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anrossi anrossi merged commit be90c9c into main Jun 20, 2025
437 of 439 checks passed
@anrossi anrossi deleted the anrossi/fix-quictls-assert branch June 20, 2025 16:14
anrossi added a commit that referenced this pull request Jul 2, 2025
anrossi added a commit that referenced this pull request Jul 9, 2025
anrossi added a commit that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants