Removed RegDeleteTreeA usage in storage_winuser

[gaurav2699]

Description

Gamecore builds are failing because it is not able to find the definition of RegDeleteTreeA in the undock pipelines.

Testing

Do any existing tests cover this change? Are new tests needed?

Documentation

Is there any documentation impact for this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.16%. Comparing base (fbcbaa2) to head (5f3013d).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5182      +/-   ##
==========================================
- Coverage   86.68%   86.16%   -0.53%     
==========================================
  Files          59       59              
  Lines       18233    18233              
==========================================
- Hits        15806    15711      -95     
- Misses       2427     2522      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[nibanks]

It seems like there is a missing include instead.

[mtfriesen]

It seems like there is a missing include instead.

I was wondering how this could be broken, but the documentation for RegDeleteTreeA says to include windows.h which we surely haven't missed?

[anrossi]

@nibanks I think gamecore specifically doesn't define the registry API, so we must define it here ourselves to build.

[nibanks]

I missed that this was gamecore specific. Generally, we just have to remove usage for things not on gamecore.

API is actually not in Gamecore

[mtfriesen]

I missed that this was gamecore specific. Generally, we just have to remove usage for things not on gamecore.

Yeah, now that I read the documentation for these partitions more carefully, if we declare functions ourselves, it's possible for Gamecore to successfully compile and maybe even link to APIs that will not be present on every Gamecore system, leading to runtime failures down the line.

[guhetier]

Oh, that would be bad and annoying.

Also, I just remembered that #5112 actually remove the use of RegDeleteTreeA and replace it with an iteration over the relevant keys. This PR might not be needed if we merge #5112.

[gaurav2699]

Added the storage_winuser part from #5112 as discussed with Anthony to unblock gamecore builds as the PR still requires changes before it gets merged.