.Net: Introduce Grounding with Google Search configuration #11804
+397
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
|
@microsoft-github-policy-service agree |
scherervictor
had a problem deploying
to
integration
GitHub Actions
Failure
|
Are there any blockers to merge this? |
markwallace-microsoft
changed the title
markwallace-microsoft
temporarily deployed
to
integration
GitHub Actions
Inactive
| { | ||
| request.Tools.Add(new GeminiTool()); | ||
| } | ||
| request.Tools[0].GoogleSearch = new GeminiTool.GoogleSearchProperties(); |
There was a problem hiding this comment.
Not fully sure of this behavior here, in theory this adds the configuration to existing tools as well, and just the first of them?
There was a problem hiding this comment.
@RogerBarreto Actually, according to their documentation combining search with function calling isn't yet supported. Ref: https://ai.google.dev/gemini-api/docs/grounding?lang=rest#configure-search
So from what I've tested, this configuration overrides the function call declaration. But I believe we could adjust to add this tool to the array instead of setting to the first one, wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR is enables the configuration of Grouding with Google Search in the Gemini API.
Description
grounding_configthat receivesgoogle_searchobjectgoogleSearchunder tools object if configured.Contribution Checklist
[Y] The code builds clean without any errors or warnings
[Y] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[Y] All unit tests pass, and I have added new tests where possible
[Y] I didn't break anyone 😄
Resolves .Net: New Feature: Gemini Grounding with Google Search #11735