.Net: Add Ollama ChatClient Extensions + UT #12476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
RogerBarreto
changed the title
RogerBarreto
had a problem deploying
to
integration
GitHub Actions
Failure
westey-m
reviewed
Jun 16, 2025
dotnet/src/IntegrationTests/Connectors/Ollama/OllamaChatClientIntegrationTests.cs
Show resolved
Hide resolved
westey-m
approved these changes
Jun 16, 2025
dmytrostruk
approved these changes
Jun 16, 2025
...ectors/Connectors.Ollama/Extensions/OllamaServiceCollectionExtensions.DependencyInjection.cs
Show resolved
Hide resolved
github-project-automation
bot
moved this from Sprint: In Review
to Sprint: Done
in Semantic Kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Successfully implemented the missing AddOllamaChatClient extensions for the Ollama Connector with comprehensive testing.:
Key Features Implemented
Same Signature Patterns: All extensions follow the exact same parameter signatures as the existing IChatCompletionService extensions
IChatClient Target: Returns IChatClient instead of IChatCompletionService
Function Calling Support: Includes UseKernelFunctionInvocation() for function calling capabilities
Comprehensive Testing: Full test coverage for all scenarios including error handling, service registration, and functionality
Integration Ready: Integration tests are ready to run when secrets are configured
Implementation
Unit Tests Created:
Integration Tests Created: