Add Microsoft.WSL profile source to schema #19047
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
approved these changes
Jun 17, 2025
|
Extracted from PR body: |
|
@DHowett you may have to admin merge since this PR only touches the schema |
|
Considering that Fragments are allowed to have any name (like |
|
(ergo, change it from an enum to a plain string in the schema) |
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
auto-merge was automatically disabled
June 19, 2025 03:19
Head branch was pushed to by a user without write access
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
|
@microsoft-github-policy-service agree |
What about now? I've relaxed the constraint to accept any string but leave the enum to keep supporting tab-completion for known variants. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
WSL now generates profiles with the source named
Microsoft.WSL, this PR adds the value to the profile schema.References and Relevant Issues
#18231