Skip to content

Add isTeamAdmin to Permission table as experiment. #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 55 commits into from
Jun 9, 2025
Merged

Conversation

dphanson63
Copy link
Collaborator

Pull Request

Relevant Issue(s): NA

Description

List team admins in permission table as proof of concept.

Bug or Feature?

  • Bug fix
  • New feature

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.00%. Comparing base (c112540) to head (1fb924f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/frontend/components/feedbackBoardContainer.tsx 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
+ Coverage   41.98%   45.00%   +3.02%     
==========================================
  Files          43       46       +3     
  Lines        3287     3355      +68     
  Branches      879      896      +17     
==========================================
+ Hits         1380     1510     +130     
+ Misses       1907     1845      -62     
Files with missing lines Coverage Δ
.../frontend/components/feedbackBoardMetadataForm.tsx 49.13% <ø> (ø)
...omponents/feedbackBoardMetadataFormPermissions.tsx 87.25% <100.00%> (+20.97%) ⬆️
src/frontend/components/feedbackBoardContainer.tsx 22.26% <90.90%> (+0.83%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2025

Bundle Report

Changes will increase total bundle size by 4.53kB (0.21%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
retrospective-extension-webpack-bundle-array-push 2.2MB 4.53kB (0.21%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: retrospective-extension-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
./reflect-bundle.js 4.53kB 2.2MB 0.21%

Files in ./reflect-bundle.js:

  • ./components/feedbackBoardMetadataFormPermissions.tsx → Total Size: 14.93kB

  • ./components/feedbackBoardContainer.tsx → Total Size: 128.41kB

  • ./components/feedbackBoardMetadataForm.tsx → Total Size: 47.12kB

Copy link
Collaborator

@polatengin polatengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 👍

@polatengin polatengin self-assigned this Jun 9, 2025
@polatengin polatengin merged commit a0f4468 into main Jun 9, 2025
7 of 8 checks passed
@polatengin polatengin deleted the dph-test-admin branch June 9, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants