Skip to content

Show total number of votes and maximum number of votes for all users #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Show total number of votes and maximum number of votes for all users #488

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
017d544
Show total number of votes by all users and maximum number of votes f…
kimsey0 Dec 9, 2022
e305dc5
Add changelog entry.
kimsey0 Dec 9, 2022
4a5c24d
Change exception handling azureDevOpsWorkService to not throw
kimsey0 Feb 2, 2023
660432c
Extend mock ExtensionDataService with mock ExtensionDataManager
kimsey0 Feb 2, 2023
d10fadd
Change mock columns object to array to support map
kimsey0 Feb 2, 2023
b74e7a4
Add simple test that the feedback board component can render
kimsey0 Feb 3, 2023
838dcd2
Fix incorrect test column ID and revert unnecessary change from objec…
kimsey0 Feb 3, 2023
0ecc80f
Add first version of test for vote count display
kimsey0 Feb 3, 2023
ddf9eea
Move WorkItemTrackingRestClient class mock into setupTests
kimsey0 Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Move WorkItemTrackingRestClient class mock into setupTests
  • Loading branch information
@kimsey0
kimsey0 committed Feb 3, 2023
commit ddf9eea5370ee046178c0fd97c032ff1a52b6ebe
4 changes: 0 additions & 4 deletions RetrospectiveExtension.Frontend/components/__tests__/feedbackBoard.test.tsx
View file
Original file line number Diff line number Diff line change
@@ -52,10 +52,6 @@ jest.mock('azure-devops-extension-api/Work/WorkClient', () => {
return { WorkRestClient: workRestClientMock };
});

jest.mock('azure-devops-extension-api/WorkItemTracking/WorkItemTrackingClient', () => ({
WorkItemTrackingRestClient: jest.fn().mockImplementation(() => ({}))
}));

jest.mock('azure-devops-extension-api/Common', () => ({
getClient: (clientClass: typeof Object) => new clientClass(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be moved into __mocks__/azure-devops-extension-api/Common/Common.tsx, but there are some of the other tests that depend on the current behavior.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a more overarching issue to maybe get the tests and components tidied eventually - may be a bit of an undertaking. For now, you should be good to go!

}));
2 changes: 1 addition & 1 deletion RetrospectiveExtension.Frontend/components/__tests__/setupTests.tsx
View file
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@ jest.mock('azure-devops-extension-api/WorkItemTracking', () => { });
jest.mock('azure-devops-extension-api/WorkItemTracking/WorkItemTracking', () => { });
jest.mock('azure-devops-extension-api/WorkItemTracking/WorkItemTrackingClient', () => {
const mockWorkItemTrackingClient = {
WorkItemTrackingRestClient: {},
WorkItemTrackingRestClient: jest.fn().mockImplementation(() => ({})),
};

return mockWorkItemTrackingClient;