Skip to content

completed the changes of the button and testimonials in Developer Page #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

linga66
Copy link
Contributor

@linga66 linga66 commented Jul 6, 2025


name: Pull Request
about: Submit changes to the project for review and inclusion

Issue ID

#265

Screen Recording

Recording.2025-07-06.184508.1.mp4

Description

The Testimonials Cards in Home page and Join Developement Page are not alligning. The Testimonials in HomePage is taking complete width.
And In Activities Showing Section in Home Page, The cards moving in vertical direction are clickable, i.e., the cursor is showing as pointer which makes the user thinks that is clickable, but when clicked it is not redirecting, and in the same section "Go to Sugar Activity page" button is clickable but the cursor is not changed when hovered

Related Issue

This PR fixes #265

Changes Made

Testimonials in home page are taking complete width and in join development are not. -> Changed the Join development's testimonials to take full width instead. If a user, for example, sees the page at 70% width, i don't want them to see the edges.
"Go to Sugar Activity page" button is clickable but the cursor is not changed when hovered -> Changed it to hover:pointer.

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes for Reviewers


Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

Copy link

github-actions bot commented Jul 6, 2025

❌ Checks Failed

Status: 🚫 Not ready to merge

Please fix the following issues before merging:

📝 Code Linting Failed

Issue: Code formatting or style violations detected.

Specific problems:

• Code formatting issues detected

How to fix:

Platform Command Description
🐧 Unix/macOS/Linux npm run format Auto-fix all formatting issues
🪟 Windows npm run format:file <filename> Fix specific files
🔍 Check Only npm run format:check Check formatting without fixing

Need help with linting? Check out the Linting Guide for Windows Users for detailed instructions.


🛠️ Next Steps

  1. Fix the issues mentioned above
  2. Test locally to ensure everything works
  3. Push your fixes to this branch
  4. Wait for re-check - This bot will automatically run again

🤖 This comment will be updated automatically when you push new commits

Copy link

github-actions bot commented Jul 6, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@FirePheonix
Copy link
Contributor

The hover pointer change is good.

And I think you've got me wrong here:
This is what I mean when I said if the viewer views it at 75% or lower width:

Developer Page (this is incorrect, since the the testimonials aren't overflowing):
SugarLabs - Google Chrome 07-07-2025 16_28_07

Whereas this is on the main page, which is correct, since even if user views at 75% width, he won't be able to see the testomonial's edges which look untidy.
SugarLabs - Google Chrome 07-07-2025 16_28_29

Make the changes, and take your time. Always there to help.

@linga66
Copy link
Contributor Author

linga66 commented Jul 7, 2025

So when we are in 75% or less, you want me to make the Developers Testimonial look same as the Testimonials in Main Page

@FirePheonix
Copy link
Contributor

no, not necessarily 75% or less.
I want the testimonials to overflow like how it has in my main page.

@sa-fw-an
Copy link
Member

sa-fw-an commented Jul 8, 2025

@linga66 whenever you're working on multiple changes, I recommend opening different PRs for each change. Don't fix everything in a single PR. If a particular change breaks, we can revert it easily if they're in separate PRs.

@linga66
Copy link
Contributor Author

linga66 commented Jul 8, 2025

no, not necessarily 75% or less.
I want the testimonials to overflow like how it has in my main page.

Sure. Noted

@linga66
Copy link
Contributor Author

linga66 commented Jul 8, 2025

@linga66 whenever you're working on multiple changes, I recommend opening different PRs for each change. Don't fix everything in a single PR. If a particular change breaks, we can revert it easily if they're in separate PRs.

Okay, I will make sure to have multiple PRs

Copy link

github-actions bot commented Jul 8, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

1 similar comment
Copy link

github-actions bot commented Jul 8, 2025

🎉 All Checks Passed!

Status: ✅ Ready to merge

✅ Completed Workflows

Workflow Status Details
🔨 Continuous Integration ✅ Passed Build completed successfully
📝 Code Linting ✅ Passed All formatting and style checks passed

🚀 This PR is ready for review and can be safely merged to main branch!

Great work! Your code meets all quality standards. 👏

@sa-fw-an sa-fw-an closed this Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Cards are Clickable but when clicked not redirecting in Home Page
3 participants