-
Notifications
You must be signed in to change notification settings - Fork 58
completed the changes of the button and testimonials in Developer Page #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completed the changes of the button and testimonials in Developer Page #279
Conversation
❌ Checks Failed
Please fix the following issues before merging: 📝 Code Linting FailedIssue: Code formatting or style violations detected. Specific problems: • Code formatting issues detected How to fix:
Need help with linting? Check out the Linting Guide for Windows Users for detailed instructions. 🛠️ Next Steps
|
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
So when we are in 75% or less, you want me to make the Developers Testimonial look same as the Testimonials in Main Page |
no, not necessarily 75% or less. |
@linga66 whenever you're working on multiple changes, I recommend opening different PRs for each change. Don't fix everything in a single PR. If a particular change breaks, we can revert it easily if they're in separate PRs. |
Sure. Noted |
Okay, I will make sure to have multiple PRs |
…fTestimonialsInDevelopersPage
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
1 similar comment
🎉 All Checks Passed!
✅ Completed Workflows
🚀 This PR is ready for review and can be safely merged to Great work! Your code meets all quality standards. 👏 |
name: Pull Request
about: Submit changes to the project for review and inclusion
Issue ID
#265
Screen Recording
Recording.2025-07-06.184508.1.mp4
Description
The Testimonials Cards in Home page and Join Developement Page are not alligning. The Testimonials in HomePage is taking complete width.
And In Activities Showing Section in Home Page, The cards moving in vertical direction are clickable, i.e., the cursor is showing as pointer which makes the user thinks that is clickable, but when clicked it is not redirecting, and in the same section "Go to Sugar Activity page" button is clickable but the cursor is not changed when hovered
Related Issue
This PR fixes #265
Changes Made
Testimonials in home page are taking complete width and in join development are not. -> Changed the Join development's testimonials to take full width instead. If a user, for example, sees the page at 70% width, i don't want them to see the edges.
"Go to Sugar Activity page" button is clickable but the cursor is not changed when hovered -> Changed it to hover:pointer.
Checklist
Additional Notes for Reviewers
Thank you for contributing to our project! We appreciate your help in improving it.
📚 See contributing instructions.
🙋🏾🙋🏼 Questions: Community Matrix Server.