-
-
Notifications
You must be signed in to change notification settings - Fork 398
Add bal:DisplayFilesInUseDialogCondition attribute to disable "Files In Use" #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add bal:DisplayFilesInUseDialogCondition attribute to disable "Files In Use" #573
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@@ -1231,34 +1231,52 @@ class CWixStandardBootstrapperApplication : public CBootstrapperApplicationBase | |||
__inout int* pResult | |||
) | |||
{ | |||
HRESULT hr = S_OK; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered if the DisplayFilesInUseDialogCondition
should be evaluated in OnExecutePackageBegin
or OnPlanPackageBegin
instead. I left it here because that's closest to its only use and that seemed clearer. Happy to move it if either of those are more appropriate places.
I have read the CLA Document and I hereby sign the CLA. |
recheck. |
@charles-juicelabs The CLA bot is very particular about the message. I believe the |
b5de212
to
f181445
Compare
@charles-juicelabs When will you resolve conflicts? Because I need this feature for my project. |
@Bondarenko1990 Tomorrow. Thank you for the reminder.
…On Wed, Apr 9, 2025 at 8:29 AM Sergii Bondarenko ***@***.***> wrote:
@charles-juicelabs <https://github.com/charles-juicelabs> When will you
resolve conflicts?
—
Reply to this email directly, view it on GitHub
<#573 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV5G3WQYVGKGMVUJGDFWDUL2YQWTPAVCNFSM6AAAAABQ5NNSSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBXGU4DOMZVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*Bondarenko1990* left a comment (wixtoolset/wix#573)
<#573 (comment)>
@charles-juicelabs <https://github.com/charles-juicelabs> When will you
resolve conflicts?
—
Reply to this email directly, view it on GitHub
<#573 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV5G3WQYVGKGMVUJGDFWDUL2YQWTPAVCNFSM6AAAAABQ5NNSSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBXGU4DOMZVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Disabling display skips showing the "Files In Use" dialog and returning a result as if the user had chosen to ignore the dialog and reboot in the case of files that were unable to be replaced.
0b96838
to
4192528
Compare
@Bondarenko1990 rebased now. |
@charles-juicelabs Could you please tell me when it will be merged into the main branch? |
Hi @robmen, I can make some time to work on this in the next few weeks. What can I do to get this change merged? It's been building installers for our releases without problem for the last six months or so. Thanks, |
We develop an application with a DLL that is loaded into many processes, largely outside of our control. It is confusing for our users when they are prompted to close these seemingly unrelated applications when we update the DLL. Updating the DLL requires a reboot independently of any files being in use anyway, so hiding the "Files In Use" dialog is a nice solution for us.
There are other examples of people wanting to disable the "Files In Use" dialog:
Add
bal:DisplayFilesInUseDialogCondition
, similar tobal::DisplayInternalUICondition
, to be added toMsiPackage
elements to control the display of "Files In Use" inWixStandardBoostrapperApplication
.For example:
Fixes wixtoolset/issues#8807.