Skip to content

Add bal:DisplayFilesInUseDialogCondition attribute to disable "Files In Use" #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

charles-juicelabs
Copy link

@charles-juicelabs charles-juicelabs commented Oct 31, 2024

We develop an application with a DLL that is loaded into many processes, largely outside of our control. It is confusing for our users when they are prompted to close these seemingly unrelated applications when we update the DLL. Updating the DLL requires a reboot independently of any files being in use anyway, so hiding the "Files In Use" dialog is a nice solution for us.

There are other examples of people wanting to disable the "Files In Use" dialog:

Add bal:DisplayFilesInUseDialogCondition, similar to bal::DisplayInternalUICondition, to be added to MsiPackage elements to control the display of "Files In Use" in WixStandardBoostrapperApplication.

For example:

<Bundle Name="...">
  <!-- ... -->
  <Chain>
    <MsiPackage 
      Id="..."
      SourceFile="..."
      bal:DisplayFilesInUseDialogCondition="no"
    />
  </Chain>
</Bundle>

Fixes wixtoolset/issues#8807.

Copy link

github-actions bot commented Oct 31, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@@ -1231,34 +1231,52 @@ class CWixStandardBootstrapperApplication : public CBootstrapperApplicationBase
__inout int* pResult
)
{
HRESULT hr = S_OK;
Copy link
Author

@charles-juicelabs charles-juicelabs Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered if the DisplayFilesInUseDialogCondition should be evaluated in OnExecutePackageBegin or OnPlanPackageBegin instead. I left it here because that's closest to its only use and that seemed clearer. Happy to move it if either of those are more appropriate places.

@charles-juicelabs
Copy link
Author

I have read the CLA Document and I hereby sign the CLA.

@charles-juicelabs
Copy link
Author

recheck.

@robmen
Copy link
Member

robmen commented Dec 26, 2024

@charles-juicelabs The CLA bot is very particular about the message. I believe the . at the end of your sentence is throwing it off.

@robmen robmen force-pushed the main branch 4 times, most recently from b5de212 to f181445 Compare February 12, 2025 23:09
@Bondarenko1990
Copy link

Bondarenko1990 commented Apr 8, 2025

@charles-juicelabs When will you resolve conflicts? Because I need this feature for my project.

@charles-juicelabs
Copy link
Author

charles-juicelabs commented Apr 9, 2025 via email

Disabling display skips showing the "Files In Use" dialog and returning
a result as if the user had chosen to ignore the dialog and reboot in
the case of files that were unable to be replaced.
@charles-juicelabs charles-juicelabs force-pushed the add-display-files-in-use-dialog-attribute branch from 0b96838 to 4192528 Compare April 10, 2025 07:08
wixbot added a commit to wixtoolset/.github that referenced this pull request Apr 10, 2025
@charles-juicelabs
Copy link
Author

@Bondarenko1990 rebased now.

@Bondarenko1990
Copy link

Bondarenko1990 commented Jun 17, 2025

@charles-juicelabs Could you please tell me when it will be merged into the main branch?

@charles-juicelabs
Copy link
Author

charles-juicelabs commented Jun 19, 2025

Hi @robmen,

I can make some time to work on this in the next few weeks. What can I do to get this change merged? It's been building installers for our releases without problem for the last six months or so.

Thanks,
Charles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide "Files In Use" dialog behaving as if ignore was chosen
3 participants