Skip to content

Add DirBrowseFlags to IisWebDirProperties #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bevanweiss
Copy link
Contributor

Adds in support for configuring IIS DirBrowseFlags to Web Directories.

Fixes wixtoolset/issues#170
Fixes wixtoolset/issues#2637
Fixes wixtoolset/issues#2917

@bevanweiss
Copy link
Contributor Author

I think it might be better to rename the Db column as a more generic 'Attributes' field, since this provides some additional bits for flags for future enhancement with other boolean settings (would have been useful if this was already in so I could have used some for these browse flags).

I think there is a test case for a 'bug' in here also (commented out).
<iis:WebDirProperties Id="TestCacheControlMaxAgeNull" CacheControlMaxAge="2147483648" />

will crash out database validation since the 2147483648 value == 0x80000000 the MSI_NULL_INTEGER...
Not sure on a good fix for it however.

  1. Perhaps just adding +1 / -1 in the compiler to avoid this specific value. or
  2. A compiler error that specifically disallows this value without the confusing error around DB validation.

Since this column addition will break the merge module back compatibility (as I understand), it should probably be coupled with some other changes to IIS schema also (ScriptTimeout I think was the other)

@robmen robmen force-pushed the main branch 4 times, most recently from b5de212 to f181445 Compare February 12, 2025 23:09
@bevanweiss bevanweiss force-pushed the iis_dirbrowseflags branch 2 times, most recently from 98bf1e7 to ab91d51 Compare March 2, 2025 11:25
@bevanweiss bevanweiss marked this pull request as ready for review March 2, 2025 11:27
@bevanweiss
Copy link
Contributor Author

This PR doesn't have the changes indicated around the Script timeouts.
I'll possibly look at this 'sometime soon'... but it's unlikely to be affecting too many WiX users.. so I might look at some of the accessibility items instead.

generic usage for other flags in future)

Fixes wixtoolset/issues#170
Fixes wixtoolset/issues#2637
Fixes wixtoolset/issues#2917

Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
MSI_NULL_INTEGER value


Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
Just checks that they don't throw errors, no actual verification yet.

Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IIS: make 'Enable Default Document' configurable IIS DefaultDocuments cannot be turned off IIS Directory Browsing Property
1 participant