Skip to content

cmd/utils: don't alter the txlookup limit in archive node #32103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

cmd/utils: don't alter the txlookup limit in archive node #32103

wants to merge 7 commits into from
+0 −6

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Jun 27, 2025

I'm running with pbss archive node, from the logs I see the preimage and full tx indexing is enabled:

INFO [06-27|01:08:48.495] Using pebble as db engine
INFO [06-27|01:08:48.508] Enabling recording of key preimages since archive mode is used
WARN [06-27|01:08:48.509] Disabled transaction unindexing for archive node

As pbss archive node is based on history.state, no need to run full indexing in archive mode

jsvisa added 2 commits June 27, 2025 02:00
@jsvisa
cmd: no need to indexing the whole blocks in pbss archive
6af5201 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
cmd: disable preimage in pbss archive
11ea6dd 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa jsvisa changed the title cmd/geth: no need to indexing full txs in pbss archive cmd: no need to index full txs in pbss archive Jun 27, 2025
rjl493456442
rjl493456442 reviewed Jun 27, 2025
View reviewed changes
jsvisa added 3 commits June 27, 2025 16:02
@jsvisa
Revert "cmd: disable preimage in pbss archive"
9779485 
This reverts commit 11ea6dd.

Signed-off-by: Delweng <delweng@gmail.com>
@jsvisa
Revert "cmd: no need to indexing the whole blocks in pbss archive"
3f3ac94 
This reverts commit 6af5201.

Signed-off-by: Delweng <delweng@gmail.com>
@jsvisa
cmd: no need to check txlookup limit in archive node
db92f7c 
Signed-off-by: Delweng <delweng@gmail.com>
@jsvisa jsvisa changed the title cmd: no need to index full txs in pbss archive cmd: no need to check the txlookup limit in archive node Jun 27, 2025
@jsvisa
enable preimage for hash only
623d45a 
Signed-off-by: Delweng <delweng@gmail.com>
@jsvisa
Copy link
Contributor Author

jsvisa commented Jun 27, 2025

Updated:

  1. disable txlookup full indexing check in archive mode
  2. enable preimage only if archive mode with hash scheme

rjl493456442
rjl493456442 reviewed Jun 27, 2025
View reviewed changes
@rjl493456442 rjl493456442 added this to the 1.16.1 milestone Jun 27, 2025
@jsvisa
Revert "enable preimage for hash only"
c66e81a 
This reverts commit 623d45a.

Signed-off-by: jsvisa <delweng@gmail.com>
@rjl493456442 rjl493456442 changed the title cmd: no need to check the txlookup limit in archive node cmd/utils: don't alter the txlookup limit in archive node Jun 30, 2025
@fjl fjl modified the milestones: 1.16.1, 1.16.2 Jul 2, 2025
@fjl
Copy link
Contributor

fjl commented Jul 8, 2025

One reason not to make this change is that transaction unindexing is very slow and causes significant I/O load. We would rather avoid this since syncing the archive node already performs so much I/O.

@fjl fjl removed the status:triage label Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.16.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jsvisa @fjl @rjl493456442