Merge pull request #19997 from hvitved/java/use-mad-in-log-injection-test

Java: Use MaD in log injection test

Author: hvitved

java/ql/test/query-tests/security/CWE-117/LogInjectionTest.ext.yml

@@ -0,0 +1,6 @@
+extensions:
+  - addsTo:
+      pack: codeql/java-all
+      extensible: sourceModel
+    data:
+      - ["loginjection", "LogInjectionTest", False, "source", "()", "", "ReturnValue", "remote", "manual"]

java/ql/test/query-tests/security/CWE-117/LogInjectionTest.java

@@ -1,3 +1,5 @@
+package loginjection;
+
 import java.util.ResourceBundle;
 import java.util.logging.LogRecord;
 import java.util.regex.Pattern;

java/ql/test/query-tests/security/CWE-117/LogInjectionTest.ql

@@ -1,11 +1,4 @@
 import java
 import semmle.code.java.security.LogInjectionQuery
 import utils.test.InlineFlowTest
-
-private class TestSource extends RemoteFlowSource {
-  TestSource() { this.asExpr().(MethodCall).getMethod().hasName("source") }
-
-  override string getSourceType() { result = "test source" }
-}
-
 import TaintFlowTest<LogInjectionConfig>