Rust: Rename type inference test inline expectation tag #20037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR renames the inline expectation tag from "method" to "target" in the Rust type inference test to better reflect the change made in #19993, where getStaticTarget was introduced to annotate all function calls (not just method calls). The tag name "target" is more accurate since it now covers both method calls and function calls.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust/ql/test/library-tests/type-inference/type-inference.ql | Updates the query to use "target" tag instead of "method" in relevant tag definitions |
| rust/ql/test/library-tests/type-inference/type-inference.expected | Updates test expectations to reflect the tag name change |
| rust/ql/test/library-tests/type-inference/pattern_matching.rs | Updates inline comments to use "target" tag instead of "method" |
| rust/ql/test/library-tests/type-inference/main.rs | Updates inline comments to use "target" tag instead of "method" |
| rust/ql/test/library-tests/type-inference/loop/main.rs | Updates inline comment to use "target" tag |
| rust/ql/test/library-tests/type-inference/dereference.rs | Updates inline comments to use "target" tag instead of "method" |
| rust/ql/lib/utils/test/internal/InlineExpectationsTestImpl.qll | Adds constructor check to ExpectationComment class |
paldepind
commented
Jul 14, 2025
| @@ -4,6 +4,8 @@ private import codeql.util.test.InlineExpectationsTest | |||
|
|
|||
| module Impl implements InlineExpectationsTestSig { | |||
| class ExpectationComment extends R::Comment { | |||
| ExpectationComment() { this.fromSource() } | |||
There was a problem hiding this comment.
There was a comment inside the standard library starting with $target, so I had to limit expectations comments to those inside the source, which seems right in any case.
geoffw0
previously approved these changes
Jul 14, 2025
|
I've merged |
geoffw0
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19993 changed the inline expectations in the type inference test such that all function calls (and not just method calls) are annotated by using
getStaticTargetin the tests. This makes the tag namemethoda bit inaccurate.This PR changes the tag name to
target.