Skip to content

fix: aws_vpc_ipam_pool_cidr netmask length diff #43262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: aws_vpc_ipam_pool_cidr netmask length diff #43262

wants to merge 2 commits into from

Conversation

Volatus
Copy link
Contributor

@Volatus Volatus commented Jul 3, 2025 •
edited
Loading

Description

This fixes the problem where importing an existing IPAM Pool CIDR can cause recreation despite the netmask lengths being identical.

Relations

Closes #43225
Relates #38614

References

Output from Acceptance Testing

❯ make testacc TESTS=TestAccIPAMPoolCIDR_ PKG=vpc
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccIPAMPoolCIDR_'  -timeout 360m -vet=off
2025/07/04 13:52:14 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/04 13:52:14 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccIPAMPoolCIDR_basic
=== PAUSE TestAccIPAMPoolCIDR_basic
=== RUN   TestAccIPAMPoolCIDR_basicNetmaskLength
=== PAUSE TestAccIPAMPoolCIDR_basicNetmaskLength
=== RUN   TestAccIPAMPoolCIDR_disappears
=== PAUSE TestAccIPAMPoolCIDR_disappears
=== RUN   TestAccIPAMPoolCIDR_Disappears_ipam
=== PAUSE TestAccIPAMPoolCIDR_Disappears_ipam
=== CONT  TestAccIPAMPoolCIDR_basic
=== CONT  TestAccIPAMPoolCIDR_disappears
=== CONT  TestAccIPAMPoolCIDR_basicNetmaskLength
=== CONT  TestAccIPAMPoolCIDR_Disappears_ipam
--- PASS: TestAccIPAMPoolCIDR_disappears (74.35s)
--- PASS: TestAccIPAMPoolCIDR_basic (75.37s)
--- PASS: TestAccIPAMPoolCIDR_Disappears_ipam (87.47s)
--- PASS: TestAccIPAMPoolCIDR_basicNetmaskLength (105.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	108.498s


...

@Volatus Volatus requested a review from a team as a code owner July 3, 2025 13:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2025 •
edited
Loading

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/vpc Issues and PRs that pertain to the vpc service. size/XS Managed by automation to categorize the size of a PR. labels Jul 3, 2025
@Volatus
fix: aws_vpc_ipam_pool_cidr netmask length diff
91409c6 
This fixes the problem where importing an existing IPAM Pool CIDR
can cause recreation despite the netmask lengths being identical.

Signed-off-by: Ismayil Mirzali <ismayil.mirzali@sap.com>
@Volatus Volatus force-pushed the fix/ipam-cidr-netmask-length-diff branch from 18ed4ed to 91409c6 Compare July 4, 2025 08:46
@Volatus
docs: add changelog for hashicorp#43262
0e96d4e 
Signed-off-by: Ismayil Mirzali <ismayil.mirzali@sap.com>
@Volatus
Copy link
Contributor Author

Volatus commented Jul 4, 2025

@jar-b @YakDriver Was wondering if you could take a look at this one when you have free time.

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 7, 2025
@Volatus
Copy link
Contributor Author

Volatus commented Jul 9, 2025

@justinretzolk
Would be great if you could give a review for this one, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/vpc Issues and PRs that pertain to the vpc service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_vpc_ipam_pool_cidr cannot be imported with netmask_length argument without replacement
2 participants
@Volatus @justinretzolk