Skip to content

Resource Identity: Adds ExistingResource tests for Framework-based resource types with ARN Identity #43273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jul 8, 2025
Merged

Resource Identity: Adds ExistingResource tests for Framework-based resource types with ARN Identity #43273

merged 30 commits into from
Jul 8, 2025

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Jul 4, 2025 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds ExistingResource tests for Framework-based resource types with ARN Identity

Fixes #43261

@gdavison gdavison requested a review from a team as a code owner July 4, 2025 06:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/apigateway Issues and PRs that pertain to the apigateway service. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/shield Issues and PRs that pertain to the shield service. service/kinesis Issues and PRs that pertain to the kinesis service. service/batch Issues and PRs that pertain to the batch service. service/securityhub Issues and PRs that pertain to the securityhub service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. service/appflow Issues and PRs that pertain to the appflow service. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. generators Relates to code generators. service/ssmcontacts Issues and PRs that pertain to the ssmcontacts service. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. service/securitylake Issues and PRs that pertain to the securitylake service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/bedrock Issues and PRs that pertain to the bedrock service. service/appfabric Issues and PRs that pertain to the appfabric service. service/paymentcryptography Issues and PRs that pertain to the paymentcryptography service. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. service/codeconnections Issues and PRs that pertain to the codeconnections service. size/XL Managed by automation to categorize the size of a PR. labels Jul 4, 2025
@gdavison gdavison force-pushed the td-framework-identity-existing-resource-tests branch from 18444d4 to dae9e70 Compare July 7, 2025 20:36
@gdavison gdavison added this to the v6.3.0 milestone Jul 7, 2025
ewbankkit
ewbankkit approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit c22286c into main Jul 8, 2025
41 checks passed
@gdavison gdavison deleted the td-framework-identity-existing-resource-tests branch July 8, 2025 17:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@gdavison gdavison mentioned this pull request Jul 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/apigateway Issues and PRs that pertain to the apigateway service. service/appfabric Issues and PRs that pertain to the appfabric service. service/appflow Issues and PRs that pertain to the appflow service. service/batch Issues and PRs that pertain to the batch service. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. service/bedrock Issues and PRs that pertain to the bedrock service. service/codeconnections Issues and PRs that pertain to the codeconnections service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/kinesis Issues and PRs that pertain to the kinesis service. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. service/paymentcryptography Issues and PRs that pertain to the paymentcryptography service. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. service/securityhub Issues and PRs that pertain to the securityhub service. service/securitylake Issues and PRs that pertain to the securitylake service. service/shield Issues and PRs that pertain to the shield service. service/ssmcontacts Issues and PRs that pertain to the ssmcontacts service. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v6.3.0
Development

Successfully merging this pull request may close these issues.

Switching to .arn from .application_arn following deprecation notice throws an error during assignment
2 participants
@gdavison @ewbankkit