Skip to content

Fix errors when use verl to train GLM4.1v model #39199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaln27
Copy link

@kaln27 kaln27 commented Jul 3, 2025

  • Support glm4v load from AutoModelForVision2Seq
  • Set glm4v model's _checkpoint_conversion_mapping attribute from None to empty dict {}

What does this PR do?

When use verl to train GLM4.1v model with GRPO, there are several small errors.
Here is how to fix them:

  • support glm4v load using AutoModelForVision2Seq
  • verl treat _checkpoint_conversion_mapping as a dict. But right now is None, which will abort the program. I also found that almost every model which don't need checkpoint convert have a empty dict.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

* Support glm4v load from AutoModelForVision2Seq
* Set glm4v model _checkpoint_conversion_mapping attr from None to {}
Copy link
Contributor

github-actions bot commented Jul 3, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto, glm4v

@kaln27
Copy link
Author

kaln27 commented Jul 3, 2025

@ArthurZucker
Hi Arthur, would you mind to review this PR?
Thank your !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant