Hide and immediately re-show window when cloaking to manage focus #40431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the palette loses focus, the window is hidden and then immediately shown again while still cloaked (invisible). This sequence ensures that focus is correctly handed off to the next window in the Z-order. It prevents the invisible palette from intercepting input and keeps the palette ready for the next activation.
This comment has been minimized.
This comment has been minimized.
zadjii-msft
added
the
Product-Command Palette
Switched both calls to PInvoke just to be consistent.
|
Closing. Succeeded by #40445. |
zadjii-msft
added a commit
that referenced
this pull request
Jul 9, 2025
this is a port of ce15032 onto main, for just the FG change. When we cloak our window, we want to make sure to _manually_ give FG back to another window. Because apparently cloaked windows can have FG. beacause that makes sense 🤦 Closes #39638 supersedes #40431 Co-authored-by: jiripolasek <me@jiripolasek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When the palette loses focus, the window is hidden and then immediately shown again while still cloaked (invisible). This sequence ensures that focus is correctly handed off to the next window in the Z-order. It prevents the invisible palette from intercepting input and keeps the palette ready for the next activation.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed