Skip to content

Restore slightly darker default border-color #41419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mdo
Copy link
Member

@mdo mdo commented Apr 29, 2025

Because people have eyes and would really like to see things lol. Saving for v5.4.0 though so it's not a surprise for folks.

Fixes #38480, fixes #41414.

@mdo mdo added the css label Apr 29, 2025
@mdo mdo requested a review from a team as a code owner April 29, 2025 04:02
@mdo mdo added this to v5.4.0 Apr 29, 2025
@github-project-automation github-project-automation bot moved this to Needs review in v5.4.0 Apr 29, 2025
@mdo mdo changed the title Restore lightly darker default border-color Restore slightly darker default border-color Apr 29, 2025
@julien-deramond julien-deramond moved this from Needs review to Review in progress in v5.4.0 May 14, 2025
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed — this change should land only in v5.4.

The new value definitely improves contrast against the white background. Approving it as-is, though I think that for form controls (like input borders, checkboxes, etc.) — and possibly other components — the color could be even darker to achieve a 3:1 contrast ratio with the white background, instead of 1.49 with this new color. 🫣

Adding Patrick as a reviewer to get his feedback as well, either for this version or potentially for a more contrasted color for v6.

@github-project-automation github-project-automation bot moved this from Review in progress to Ready to merge in v5.4.0 May 14, 2025
@patrickhlauke
Copy link
Member

The new value definitely improves contrast against the white background. Approving it as-is, though I think that for form controls (like input borders, checkboxes, etc.) — and possibly other components — the color could be even darker to achieve a 3:1 contrast ratio with the white background, instead of 1.49 with this new color. 🫣

Adding Patrick as a reviewer to get his feedback as well, either for this version or potentially for a more contrasted color for v6.

Agree we can merge this now, but would be good to darken a tad more to hit 3:1 if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready to merge
Development

Successfully merging this pull request may close these issues.

Insufficient contrast on borders New check/radio input styles lack sufficient contrast
3 participants