Skip to content

Commit 00471a7

Browse files
committed
[BlinkHelpers] Fix rare_data_ and rendering_data_ extended fields on blink::Node
1 parent df25928 commit 00471a7

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

extensions/target-specific/chromium/blink/blink-helpers/blink-helpers.js

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -42,18 +42,6 @@ Loader.OnLoad(function() {
4242
});
4343
}));
4444

45-
DbgObject.AddExtendedField(Chromium.RendererProcessType("blink::Node"), "rare_data_", Chromium.RendererProcessType("blink::NodeRareData"), UserEditableFunctions.Create((node) => {
46-
return Promise.all([node.f("node_flags_").val(), DbgObject.constantValue(Chromium.RendererProcessType("blink::Node::NodeFlags"), "kHasRareDataFlag")])
47-
.thenAll((nodeFlags, hasRareDataFlag) => {
48-
var nodeHasRareData = nodeFlags & hasRareDataFlag;
49-
if (nodeHasRareData) {
50-
return node.f("data_").F("Object").f("rare_data_").F("Object").as(Chromium.RendererProcessType("blink::NodeRareData"));
51-
} else {
52-
return DbgObject.NULL;
53-
}
54-
});
55-
}));
56-
5745
DbgObject.AddExtendedField(Chromium.RendererProcessType("blink::NodeRareData"), "element_rare_data_", Chromium.RendererProcessType("blink::ElementRareData"), UserEditableFunctions.Create((nodeRareData) => {
5846
return nodeRareData.f("is_element_rare_data_").val()
5947
.then(null, () => {
@@ -99,9 +87,21 @@ Loader.OnLoad(function() {
9987
});
10088
}
10189

102-
DbgObject.AddExtendedField(Chromium.RendererProcessType("blink::Node"), "node_rendering_data_", Chromium.RendererProcessType("blink::NodeRenderingData"), UserEditableFunctions.Create((node) => {
90+
DbgObject.AddExtendedField(Chromium.RendererProcessType("blink::Node"), "rare_data_", Chromium.RendererProcessType("blink::NodeRareData"), UserEditableFunctions.Create((node) => {
91+
return Promise.all([node.f("node_flags_").val(), DbgObject.constantValue(Chromium.RendererProcessType("blink::Node::NodeFlags"), "kHasRareDataFlag")])
92+
.thenAll((nodeFlags, hasRareDataFlag) => {
93+
var nodeHasRareData = nodeFlags & hasRareDataFlag;
94+
if (nodeHasRareData) {
95+
return node.f("data_").F("Object").as(Chromium.RendererProcessType("blink::NodeRareData"));
96+
} else {
97+
return DbgObject.NULL;
98+
}
99+
});
100+
}));
101+
102+
DbgObject.AddExtendedField(Chromium.RendererProcessType("blink::Node"), "rendering_data_", Chromium.RendererProcessType("blink::NodeRenderingData"), UserEditableFunctions.Create((node) => {
103103
return node.F("rare_data_")
104-
.then((nodeRareData) => (!nodeRareData.isNull() ? nodeRareData : node.f("data_").F("Object")).as(Chromium.RendererProcessType("blink::NodeRenderingData")));
104+
.then((nodeRareData) => (!nodeRareData.isNull() ? nodeRareData.f("node_layout_data_").F("Object") : node.f("data_").F("Object")).as(Chromium.RendererProcessType("blink::NodeRenderingData")));
105105
}));
106106

107107
function getCollectionFromOwnerNode(node, collectionTypeOrPromise) {
@@ -882,7 +882,7 @@ Loader.OnLoad(function() {
882882
`You may still specify a ${typenames_for_error.join(' or ')} explicitly.`;
883883
return Promise.reject(errorMessage);
884884
} else {
885-
return Promise.map(documents, (document) => document.F("node_rendering_data_").f("layout_object_").F("Object").vcast());
885+
return Promise.map(documents, (document) => document.F("rendering_data_").f("layout_object_").F("Object").vcast());
886886
}
887887
}, (error) => {
888888
var errorMessage = ErrorMessages.CreateErrorsList(error) +

0 commit comments

Comments
 (0)