[JitDiff X64] [EgorBo] Remove a few unsafe bits in S.P.Uri, S.N.Ping, System ...

[MihuBot]

Job completed in 15 minutes 18 seconds (remote runner delay: 1 minute 5 seconds).
dotnet/runtime#116281

Diffs

Found 84 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 40578567
Total bytes of diff: 40578561
Total bytes of delta: -6 (-0.00 % of base)
Total relative delta: 0.10
    diff is an improvement.
    relative diff is a regression.


Total byte diff includes -68 bytes from reconciling methods
	Base had    1 unique methods,      121 unique bytes
	Diff had    8 unique methods,       53 unique bytes

Top file improvements (bytes):
          -6 : System.Private.Uri.dasm (-0.01 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 259 unchanged.

Top method regressions (bytes):
          62 (10.44 % of base) : System.Private.Uri.dasm - System.Net.IPv4AddressHelper:ParseCanonicalName(System.String,int,int,byref):System.String (FullOpts)
           7 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[double,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[int,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[long,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[short,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Nullable`1[int],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Numerics.Vector`1[float],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[ubyte,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           4 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.__Canon,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)

Top method improvements (bytes):
        -121 (-100.00 % of base) : System.Private.Uri.dasm - System.Net.IPv4AddressHelper:Parse(System.String,ulong,int,int):ubyte (FullOpts) (1 base, 0 diff methods)

Top method regressions (percentages):
           7 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[double,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[int,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[long,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[short,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           4 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.__Canon,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Nullable`1[int],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Numerics.Vector`1[float],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           7 (Infinity of base) : System.Private.Uri.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[ubyte,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
          62 (10.44 % of base) : System.Private.Uri.dasm - System.Net.IPv4AddressHelper:ParseCanonicalName(System.String,int,int,byref):System.String (FullOpts)

Top method improvements (percentages):
        -121 (-100.00 % of base) : System.Private.Uri.dasm - System.Net.IPv4AddressHelper:Parse(System.String,ulong,int,int):ubyte (FullOpts) (1 base, 0 diff methods)

10 total methods with Code Size differences (1 improved, 9 regressed), 245507 unchanged.

--------------------------------------------------------------------------------

Artifacts:

• build-clr-checked-main.zip (87 MB)
• build-artifacts-main.zip (673 MB)
• build-clr-checked-pr.zip (87 MB)
• build-artifacts-pr.zip (91 MB)
• jit-diffs-main.zip (135 MB)
• jit-diffs-pr.zip (135 MB)
• diff-frameworks.txt (5 KB)
• ShortDiffsRegressions.md (107 B)
• LongDiffsRegressions.md (73 KB)

[MihuBot]

Top method regressions

Note: some changes were skipped as they were too large to fit into a comment.

Larger list of diffs: https://gist.github.com/MihuBot/ddd94ef70233e1a2500730302f7269d5

[MihuBot]

@EgorBo