Tweak operation absorbtion (ex. Unindent Concatenation) #307
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2025-05-27/64870/1 |
piegamesde
force-pushed
the
unindent-concatenation
branch
2 times, most recently
from
ab7d1f8 to
2022fef
Compare
jfly
left a comment
jfly
left a comment
There was a problem hiding this comment.
I skimmed the code, but between limited Haskell experience and limited time, I wasn't able to give any useful feedback on the code.
Left some thoughts/nits on the tests. I also skimmed the nixpkgs diff.
I'm surprised that this commit had no effect on nixpkgs: infinixbot/nixpkgs@6e9d96e. Does the change actually do anything?
I'm giving you a shipit, but am also asking/trusting you to seek feedback from more tenured members of the team if you feel it's needed here!
piegamesde
force-pushed
the
unindent-concatenation
branch
from
2022fef to
e9770be
Compare
|
@jfly I've now rewritten the changes to better highlight what each bit of the code is doing, that should hopefully clear things up. With the new diff, we should be able to answer the question whether or not we still want to keep the old special case |
piegamesde
force-pushed
the
unindent-concatenation
branch
from
750c455 to
8d96947
Compare
piegamesde
force-pushed
the
unindent-concatenation
branch
from
8d96947 to
69196c1
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2025-06-24/66031/1 |
piegamesde
force-pushed
the
unindent-concatenation
branch
4 times, most recently
from
a9d77e6 to
bb9a9df
Compare
piegamesde
force-pushed
the
unindent-concatenation
branch
from
bb9a9df to
3a3e0d3
Compare
piegamesde
force-pushed
the
unindent-concatenation
branch
from
3a3e0d3 to
7e22758
Compare
piegamesde
changed the title
We don't need it anymore, case 1 covers every good aspect of it but in better
piegamesde
force-pushed
the
unindent-concatenation
branch
from
58dd0c9 to
aed61db
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2025-07-08/66454/1 |
4 participants
Quick experiment for #228 #284. Honestly I'm more "vibe coding" than anything else here, this issue is stretching our engine past its limits, and properly reasoning about what which knobs to turn is really expensive on brainpower
Closes #228, Closes #309