-
Notifications
You must be signed in to change notification settings - Fork 184
fix(api,app): Block protocol start if the Flex Stacker is not homed or shuttle is missing + home stacker from Desktop app. #18701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r shuttle is missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock since this is time sensitive, but there's some small things I think we can improve
app/src/organisms/Desktop/Devices/ProtocolRun/SetupModuleAndDeck/SetupModulesList.tsx
Outdated
Show resolved
Hide resolved
m => m.attachedModuleMatch?.moduleOffset?.last_modified == null | ||
) | ||
moduleData.some(m => { | ||
if (m.attachedModuleMatch?.moduleType === FLEX_STACKER_MODULE_TYPE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably not the right place fo rthis, since it will disable the run button with "calibrate attached module(s) to continue" - wants its own reason, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smb2268 and I spoke about it,
I think it should be, I think the confusion is that calibration is now a part of the greater "Module Setup" flow. However, some areas reference "calibration required," which should say "Module Setup Required" or something similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke to design, will change the copy to "Action needed".
…ded" per design move PlatformState.MISSING logic into `get_platform_sensor_state` method of the FlexStacker Reader since we need up-to-date limit switch status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on robot and worked as expected
7376a7f
to
69a3e72
Compare
Overview
The Flex stacker Platform might not always be at the homed (gripper) position, which could cause a problem when loading labware on a stacker occupied column 4, since the labware would not be physically where we expected. So let's ensure we can't start the protocol if the relevant stackers are not homed or the shuttle is missing. The Platform missing status coming from the backend was also wrong, let's also fix that.
Stacker needs home
Stacker Missing shuttle
Module needs setup
Modules and fixtures ready
Closes: EXEC-1563 EXEC-1572
Test Plan and Hands on Testing
Changelog
PlatformState.MISSING
logic to theget_platform_sensor_state
method of the FlexStacker Reader, since we need up-to-date limit switch statusReview requests
Risk assessment
Low, unreleased.