Skip to content

docs(api): resolve TODO for 2.23 changes to InstrumentContext.name #18702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

ecormany
Copy link
Contributor

@ecormany ecormany commented Jun 21, 2025

Overview

See here's the thing about TODOs: you actually have to do them.

thx @ddcc4

Test Plan and Hands on Testing

there's a sandbox

Changelog

uncommented the thing we were supposed to a while ago!

Risk assessment

negative

@ecormany ecormany requested a review from a team as a code owner June 21, 2025 02:22
@ecormany ecormany requested review from ddcc4 and removed request for a team June 21, 2025 02:22
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@ecormany ecormany added docs papi-v2 Python API V2 labels Jun 23, 2025
@ecormany ecormany merged commit 22e2651 into chore_release-8.5.0 Jun 23, 2025
38 of 40 checks passed
@ecormany ecormany deleted the pipette-name-todo-finally branch June 23, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs papi-v2 Python API V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants