Skip to content

fix(protocol-designer): timeline configurations padding adjustment #18705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jun 23, 2025

closes RQA-4288

Overview

Configuration section should have 12px padding on all sides

Screenshot 2025-06-23 at 10 43 23

Test Plan and Hands on Testing

check that it matches designs from the ticket.

Changelog

  • fix padding

Risk assessment

low

@jerader jerader requested a review from a team as a code owner June 23, 2025 14:44
@jerader jerader requested a review from koji June 23, 2025 14:44
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.71%. Comparing base (b3bbb05) to head (0075e39).
Report is 1 commits behind head on chore_release-pd-8.5.0.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           chore_release-pd-8.5.0   #18705      +/-   ##
==========================================================
- Coverage                   23.99%   23.71%   -0.29%     
==========================================================
  Files                        3288     3288              
  Lines                      285965   285957       -8     
  Branches                    29421    29414       -7     
==========================================================
- Hits                        68608    67801     -807     
- Misses                     217332   218131     +799     
  Partials                       25       25              
Flag Coverage Δ
protocol-designer 19.05% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Designer/ProtocolSteps/Timeline/Configurations.tsx 100.00% <100.00%> (ø)

... and 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jerader jerader merged commit bb094a6 into chore_release-pd-8.5.0 Jun 23, 2025
26 checks passed
@jerader jerader deleted the pd_fix-padding-timeline branch June 23, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants