Skip to content

feat(protocol-designer): wire up deck_configuration i18n file #18706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jun 23, 2025

Overview

Wire up the deck_configuration i18n strings to work for deck configurator in PD.

Test Plan and Hands on Testing

Go through deck setup and see that the fixtures to add to the deck map have correct copy.

Changelog

  • export deck config i18n file

Risk assessment

low

@jerader jerader requested a review from a team as a code owner June 23, 2025 15:14
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.75%. Comparing base (981511a) to head (c28a3e3).
Report is 6 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #18706   +/-   ##
=======================================
  Coverage   24.75%   24.75%           
=======================================
  Files        3284     3284           
  Lines      285464   285417   -47     
  Branches    28663    28655    -8     
=======================================
+ Hits        70662    70663    +1     
+ Misses     214781   214733   -48     
  Partials       21       21           
Flag Coverage Δ
protocol-designer 19.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tocol-designer/src/assets/localization/en/index.ts 92.00% <100.00%> (+0.33%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@ddcc4 ddcc4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this for PD 8.5.0?

@jerader
Copy link
Collaborator Author

jerader commented Jun 23, 2025

You don't need this for PD 8.5.0?

@ddcc4 nope! this is for edge only 😄

@jerader jerader merged commit 3cfbec4 into edge Jun 23, 2025
22 checks passed
@jerader jerader deleted the pd_deck-config-i18n branch June 23, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants