fix(shared-data): update lc display names #18711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-8.5.0 #18711 +/- ##
=======================================================
- Coverage 23.45% 23.40% -0.06%
=======================================================
Files 3261 3193 -68
Lines 281732 267476 -14256
Branches 29042 27725 -1317
=======================================================
- Hits 66083 62599 -3484
+ Misses 215629 204857 -10772
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jerader
reviewed
Jun 23, 2025
| screen.getByText('80% ethanol') | ||
|
|
||
| fireEvent.click( | ||
| screen.getByRole('label', { name: 'Aqueous Deionized water' }) | ||
| screen.getByRole('label', { name: 'Aqueous (Deionized water) Deionized water' }) |
There was a problem hiding this comment.
this seems funny that deionized water is listed twice. let me take a look after my meeting.
jerader
approved these changes
Jun 23, 2025
|
Hi Sanniti, this seems to have broken a test. If you check out I'm getting the test failure |
ddcc4
added a commit
that referenced
this pull request
Jun 25, 2025
…ass displayNames (#18738) # Overview This fixes a broken test after PR #18711, which changed the names of our liquid classes (AUTH-2003). Specifically, we renamed `Volatile` to `Volatile (80% ethanol)`. ## Test Plan and Hands on Testing Ran test locally. Will also see if CI tests pass. ## Risk assessment Low, test only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes AUTH-2003
Overview
Updates the display names to correct ones shown in design proposals.
Review requests
Risk assessment
None.