-
Notifications
You must be signed in to change notification settings - Fork 183
feat(app): Implement Stacker Location Identify #18721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18721 +/- ##
==========================================
+ Coverage 24.75% 25.72% +0.96%
==========================================
Files 3284 3284
Lines 285651 286042 +391
Branches 28648 29115 +467
==========================================
+ Hits 70718 73576 +2858
+ Misses 214912 212440 -2472
- Partials 21 26 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
const module = | ||
unconfiguredMods?.find(m => m.serialNumber === fixtureSerialNumber) ?? | ||
null | ||
if (module !== null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a useState
variable that gets set when we identify the module and blocks when identifying, the variable is then cleared once the timer expires. This prevents multiple timers from going off simultaneously, which causes the stacker to identify incorrectly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good,
Left a comment on what we spoke about IRL, I think this is good to go once we add that!
</TertiaryButton> | ||
</ListItem> | ||
) | ||
<StyledText desktopStyle="bodyDefaultSemiBold">{optionName}</StyledText> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll also need odd style for this text - it should be oddStyle="bodyTextSemiBold"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I made this ticket as a follow up to address the FixtureOption CTA issue: https://opentrons.atlassian.net/browse/EXEC-1634
Overview
Covers EXEC-1417
Now when adding a Stacker to the Deck Configuration an "Identify" button will appear next to the "Add" button. When pressing it will blink the Stacker LED for 10 seconds. If the stacker is added the stacker will cease blinking immediately.
Screencap:

Test Plan and Hands on Testing
Changelog
Added new Fixture Add modal case for showing multiple buttons (in this case the identify button).
Review requests
Any other protection cases we need for this? For now this only appears on the stacker modules, but I've planned it to be scalable enough for other identifiable modules in the future. The hook
useSendIdentifyStacker
will need to be replaced if we ever have other modules with toggleable LEDs.Risk assessment
Medium/Low - Modified existing modal but only for new module behavior.