Skip to content

chore(ci): include matrix.with-ot-hardware in test name to tell tests apart #18745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

ddcc4
Copy link
Contributor

@ddcc4 ddcc4 commented Jun 26, 2025

Overview

Some time ago, we added with-ot-hardware: ['true', 'false'] to the test matrix for the opentrons package tests, but we didn't update the test name with the new variable. This makes it look like the same test is running twice in CI, which is confusing:

This change just adds the with-ot-hardware to the test name.

Test Plan and Hands on Testing

Run the CI tests and see.

Risk assessment

Low, cosmetic change for Github display.

@ddcc4 ddcc4 requested a review from a team as a code owner June 26, 2025 01:16
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@ddcc4 ddcc4 merged commit ec1cfa1 into chore_release-8.5.0 Jun 26, 2025
19 checks passed
@ddcc4 ddcc4 deleted the dc-test-name branch June 26, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants