Skip to content

refactor(app): Prepare getRunLabwareRenderInfo() for labware schema 3 #18751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: edge
Choose a base branch
from

Conversation

SyntaxColoring
Copy link
Contributor

Overview

Another small chunk towards EXEC-1278.

getRunLabwareRenderInfo() is a helper used by a couple of organisms in app/. Given some run data, it returns a structure of all labware that can be shown on a deck map, and the coordinates where those labware should be shown. This adjusts the coordinate math so it does the right thing when given a labware definition in schema 3.

See also #18735, which deletes an unused function that's largely duplicated with this one.

Test Plan and Hands on Testing

To do.

Review requests

To do.

Risk assessment

To do.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner June 26, 2025 18:03
@SyntaxColoring SyntaxColoring requested review from smb2268 and mjhuff and removed request for a team and smb2268 June 26, 2025 18:03
@SyntaxColoring SyntaxColoring marked this pull request as draft June 26, 2025 18:03
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 1.40845% with 70 lines in your changes missing coverage. Please review.

Project coverage is 25.92%. Comparing base (5360a40) to head (ecfb1df).
Report is 21 commits behind head on edge.

Files with missing lines Patch % Lines
...InterventionModal/utils/getRunLabwareRenderInfo.ts 0.00% 42 Missing ⚠️
shared-data/js/helpers/labwareSchemaShims.ts 6.66% 14 Missing ⚠️
.../ErrorRecoveryFlows/shared/TwoColLwInfoAndDeck.tsx 0.00% 7 Missing ⚠️
...terventionModal/MoveLabwareInterventionContent.tsx 0.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18751      +/-   ##
==========================================
+ Coverage   25.65%   25.92%   +0.27%     
==========================================
  Files        3284     3284              
  Lines      285698   286241     +543     
  Branches    28658    29194     +536     
==========================================
+ Hits        73290    74206     +916     
+ Misses     212381   212008     -373     
  Partials       27       27              
Flag Coverage Δ
protocol-designer 19.36% <1.40%> (+0.29%) ⬆️
step-generation 5.59% <1.40%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../ErrorRecoveryFlows/shared/TwoColLwInfoAndDeck.tsx 0.00% <0.00%> (ø)
...terventionModal/MoveLabwareInterventionContent.tsx 0.00% <0.00%> (ø)
shared-data/js/helpers/labwareSchemaShims.ts 29.09% <6.66%> (-3.55%) ⬇️
...InterventionModal/utils/getRunLabwareRenderInfo.ts 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant