Skip to content

chore(app): refactor the way we check for slot placement #18752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 2, 2025

Conversation

TamarZanzouri
Copy link
Contributor

@TamarZanzouri TamarZanzouri commented Jun 26, 2025

Overview

refactor the way we find what slot an AA is assigned to.
minor bug fixes

Test Plan and Hands on Testing

make sure the logic related to adding removing an item from the deck config is working as expected.

Changelog

add a mapping between a AA to a VS

Review requests

changes make sense?

Risk assessment

Medium. should make sure logic was not affected

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 38.38384% with 122 lines in your changes missing coverage. Please review.

Project coverage is 25.68%. Comparing base (62399f5) to head (f1d2385).
Report is 5 commits behind head on edge.

Files with missing lines Patch % Lines
shared-data/js/fixtures.ts 51.70% 71 Missing ⚠️
.../organisms/DeviceDetailsDeckConfiguration/utils.ts 0.00% 41 Missing ⚠️
...organisms/DeviceDetailsDeckConfiguration/index.tsx 0.00% 5 Missing ⚠️
...DeviceDetailsDeckConfiguration/AddFixtureModal.tsx 0.00% 3 Missing ⚠️
...ocolSetup/ProtocolSetupDeckConfiguration/index.tsx 0.00% 1 Missing ⚠️
...uration/hooks/useDeckConfigurationEditingTools.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18752      +/-   ##
==========================================
- Coverage   26.13%   25.68%   -0.45%     
==========================================
  Files        3290     3287       -3     
  Lines      286993   286501     -492     
  Branches    29604    29275     -329     
==========================================
- Hits        75005    73597    -1408     
- Misses     211957   212876     +919     
+ Partials       31       28       -3     
Flag Coverage Δ
step-generation 5.35% <37.87%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ocolSetup/ProtocolSetupDeckConfiguration/index.tsx 0.00% <0.00%> (ø)
...uration/hooks/useDeckConfigurationEditingTools.tsx 0.00% <0.00%> (ø)
...DeviceDetailsDeckConfiguration/AddFixtureModal.tsx 0.00% <0.00%> (ø)
...organisms/DeviceDetailsDeckConfiguration/index.tsx 0.00% <0.00%> (ø)
.../organisms/DeviceDetailsDeckConfiguration/utils.ts 0.00% <0.00%> (ø)
shared-data/js/fixtures.ts 46.58% <51.70%> (-27.06%) ⬇️

... and 139 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TamarZanzouri TamarZanzouri changed the title Small bug fixes chore(app): refactor the way we check for slot placement Jul 2, 2025
@TamarZanzouri TamarZanzouri marked this pull request as ready for review July 2, 2025 14:56
@TamarZanzouri TamarZanzouri requested a review from a team as a code owner July 2, 2025 14:56
@TamarZanzouri TamarZanzouri requested review from smb2268 and sfoster1 and removed request for a team July 2, 2025 14:56
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, solid improvement. Couple small things to fix noted inline. Can you add more information about what a visual slot is to the pr def?

@TamarZanzouri TamarZanzouri merged commit 094291c into edge Jul 2, 2025
52 checks passed
@TamarZanzouri TamarZanzouri deleted the small-bug-fixes branch July 2, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants