-
Notifications
You must be signed in to change notification settings - Fork 183
chore(app): refactor the way we check for slot placement #18752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18752 +/- ##
==========================================
- Coverage 26.13% 25.68% -0.45%
==========================================
Files 3290 3287 -3
Lines 286993 286501 -492
Branches 29604 29275 -329
==========================================
- Hits 75005 73597 -1408
- Misses 211957 212876 +919
+ Partials 31 28 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
app/src/organisms/DeviceDetailsDeckConfiguration/__tests__/utils.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, solid improvement. Couple small things to fix noted inline. Can you add more information about what a visual slot is to the pr def?
Overview
refactor the way we find what slot an AA is assigned to.
minor bug fixes
Test Plan and Hands on Testing
make sure the logic related to adding removing an item from the deck config is working as expected.
Changelog
add a mapping between a AA to a VS
Review requests
changes make sense?
Risk assessment
Medium. should make sure logic was not affected