fix(step-generation): list off-deck labware last in tip_racks arg

[jerader]

closes RQA-4309

Overview

Alex ran into a bug where the tip_racks arg in load_instrument for loading a pipette listed off-deck labware too soon, so analysis would fail thinking the tiprack to use was off-deck.

This analysis error wasn't caught in PD because PD's getNextTip logic lists off-deck tipracks last. So you will use all your tips on deck first before running into the "tip is off deck" error. We needed the python to match this by also listing off-deck labware last.

Test Plan and Hands on Testing

You can smoke test but also i added test coverage to test this. so just review the code!

Changelog

• list off-deck labware last
• add test overage

Risk assessment

low

[codecov]

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 25.66%. Comparing base (a5adfb8) to head (dd26451).
Report is 2 commits behind head on chore_release-pd-8.5.0.

Files with missing lines	Patch %	Lines
...organisms/ODD/QuickTransferFlow/utils/pythonDef.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                    Coverage Diff                     @@
##           chore_release-pd-8.5.0   #18758      +/-   ##
==========================================================
+ Coverage                   25.65%   25.66%   +0.01%     
==========================================================
  Files                        3219     3219              
  Lines                      278627   278652      +25     
  Branches                    28962    28985      +23     
==========================================================
+ Hits                        71472    71524      +52     
+ Misses                     207126   207099      -27     
  Partials                       29       29              

Flag	Coverage Δ
protocol-designer	19.12% <96.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
step-generation/src/utils/pythonFileUtils.ts	88.14% <100.00%> (+0.46%)	⬆️
...organisms/ODD/QuickTransferFlow/utils/pythonDef.ts	0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ddcc4]

This is fine. It might take slightly less brainpower for a reader if you just split it into 2 lists though, like:

const onDeckTipracks = allTipracks.filter(...)
const offDeckTipracks = allTipracks.filter(...)
const tiprackPythonNames = [...onDeckTipracks, ...offDeckTipracks].map(...)

[jerader]

oh ya i like that better actualy. i'm going to change it. thanks!

[koji]

probably protecting the original array would be better.

Suggested change

	const tiprackPythonNames = allTipracks
	const tiprackPythonNames = [...allTipracks]