feat(app) add third step to blowout #18760

koji · 2025-06-26T23:58:00Z

Overview

noticed that I forgot to add third screen to BlowOut

clsoe AUTH-1931

Test Plan and Hands on Testing

Changelog

add third screen
remove test for the previous BlowOut

Review requests

Risk assessment

low

add third screen to blow out close AUTH-1931

codecov · 2025-06-27T00:15:47Z

Codecov Report

Attention: Patch coverage is 0.65789% with 302 lines in your changes missing coverage. Please review.

Project coverage is 62.73%. Comparing base (f823458) to head (9eff8a5).
Report is 5 commits behind head on edge.

Files with missing lines	Patch %	Lines
...sferFlow/QuickTransferAdvancedSettings/BlowOut.tsx	0.00%	150 Missing ⚠️
...ms/ODD/QuickTransferFlow/utils/getMaxUiFlowRate.ts	0.00%	66 Missing ⚠️
...ickTransferFlow/utils/generateQuickTransferArgs.ts	0.00%	23 Missing ⚠️
...TransferFlow/utils/getExtractTiprackTypeFromURI.ts	7.69%	12 Missing ⚠️
...ansferFlow/QuickTransferAdvancedSettings/index.tsx	0.00%	10 Missing ⚠️
...isms/ODD/QuickTransferFlow/utils/getPipetteName.ts	9.09%	10 Missing ⚠️
...erFlow/Dispense/hooks/useDispenseSettingsConfig.ts	0.00%	9 Missing ⚠️
...w/QuickTransferAdvancedSettings/DisposalVolume.tsx	0.00%	9 Missing ⚠️
.../QuickTransferFlow/utils/getInitialSummaryState.ts	0.00%	7 Missing ⚠️
...pp/src/organisms/ODD/QuickTransferFlow/reducers.ts	0.00%	5 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##             edge   #18760      +/-   ##
==========================================
- Coverage   62.81%   62.73%   -0.08%     
==========================================
  Files        3250     3253       +3     
  Lines      257655   257824     +169     
  Branches    32754    32717      -37     
==========================================
- Hits       161835   161742      -93     
- Misses      95622    95884     +262     
  Partials      198      198

Flag	Coverage Δ
step-generation	`5.34% <0.65%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
app/src/organisms/ODD/QuickTransferFlow/types.ts	`100.00% <ø> (ø)`
...src/organisms/ODD/QuickTransferFlow/utils/index.ts	`100.00% <ø> (ø)`
...Flow/QuickTransferAdvancedSettings/PipettePath.tsx	`96.27% <0.00%> (-0.54%)`	⬇️
...pp/src/organisms/ODD/QuickTransferFlow/reducers.ts	`1.09% <0.00%> (-0.02%)`	⬇️
.../QuickTransferFlow/utils/getInitialSummaryState.ts	`76.00% <0.00%> (-8.06%)`	⬇️
...erFlow/Dispense/hooks/useDispenseSettingsConfig.ts	`51.50% <0.00%> (-0.53%)`	⬇️
...w/QuickTransferAdvancedSettings/DisposalVolume.tsx	`83.89% <0.00%> (-0.75%)`	⬇️
...ansferFlow/QuickTransferAdvancedSettings/index.tsx	`91.20% <0.00%> (-1.46%)`	⬇️
...isms/ODD/QuickTransferFlow/utils/getPipetteName.ts	`9.09% <9.09%> (ø)`
...TransferFlow/utils/getExtractTiprackTypeFromURI.ts	`7.69% <7.69%> (ø)`
... and 3 more

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jerader · 2025-06-27T12:29:00Z

app/src/organisms/ODD/QuickTransferFlow/QuickTransferAdvancedSettings/BlowOut.tsx

+      ? liquidSpecs.lowVolumeDefault.supportedTips[tipType]
+      : liquidSpecs.default.supportedTips[tipType]
+  const minFlowRate = 1
+  const maxFlowRate = Math.floor(flowRatesForSupportedTip?.uiMaxFlowRate ?? 0)


i think @ncdiehl11 is using some util to get max flow rate for PD - probably want them to align!

Hey @koji, I have a utility for getMaxUIFlowRate that maybe you can use for consistency

jerader · 2025-06-27T12:29:19Z

app/src/organisms/ODD/QuickTransferFlow/QuickTransferAdvancedSettings/DisposalVolume.tsx

-    pipetteName = pipetteName + `_96`
-  }
-
+  const pipetteName = getPipetteName(state.pipette)


...src/organisms/ODD/QuickTransferFlow/QuickTransferAdvancedSettings/__tests__/Blowout.test.tsx

jerader · 2025-06-27T12:30:27Z

app/src/organisms/ODD/QuickTransferFlow/utils/getInitialSummaryState.ts

+      path === 'multiDispense'
+        ? {
+            location: trashConfigCutout,
+            speed: flowRatesForSupportedTip.defaultDispenseFlowRate.default,


ya lets check on this speed flow rate too. i think @ncdiehl11 uses a util for this in PD as well

We want to get our initial advanced args based on the following:

volume

pipette

tip

path

liquid class

I have a large utility getLiquidClassesValues in PD that takes in the above information, and returns a flattened PD form with the liquid class defaults. I think we probably need something similar here for QT, but instead of mapping to a form, it will map to the QT state. Maybe we should chat about this in more depth

i have a working branch for getLiquidClassesValues.
this will be resolve by a following pr.

app/src/organisms/ODD/QuickTransferFlow/types.ts

ncdiehl11 · 2025-07-07T14:09:04Z

app/src/organisms/ODD/QuickTransferFlow/Dispense/hooks/useDispenseSettingsConfig.ts

@@ -31,18 +31,21 @@ export function useDispenseSettingsConfig({
  const { makeSnackbar } = useToaster()

  const getBlowoutValueCopy = (): string | undefined => {


does this need to be a function?

app/src/organisms/ODD/QuickTransferFlow/QuickTransferAdvancedSettings/BlowOut.tsx

app/src/organisms/ODD/QuickTransferFlow/types.ts

ncdiehl11 · 2025-07-07T14:29:05Z

app/src/organisms/ODD/QuickTransferFlow/utils/getMaxUiFlowRate.ts

Should we consolidate the same utility to a shared location rather than have two instances of it, one in PD and one in app?

PM team's request is to aling app's functionality with pd's one, so having the shared utility would be great.

Maybe we can ticket this so we don't forget? I'm OK with addressing in a followup, though

where would be a good place for the ticket?

PD post-launch backlog?

ncdiehl11

I'm good with merging this! I left one comment about consolidating logic for max UI flow rate in PD/App.

ncdiehl11 · 2025-07-07T19:08:03Z

app/src/organisms/ODD/QuickTransferFlow/utils/getMaxUiFlowRate.ts

As discussed in comment above, let's ticket a refactor to share this utility with PD/App in a followup

issued the ticket for this.
i will follow up when I finish the QT work.

https://opentrons.atlassian.net/browse/AUTH-2039

koji added 3 commits June 26, 2025 19:51

feat(app): add third screen to blow out

0920cef

add third screen to blow out close AUTH-1931

fix tests

1362154

fix test update dispatch item name

2f431ac

koji requested review from ncdiehl11 and jerader June 26, 2025 23:58

update blowout to blowOutDispense

23b305c

koji added the authorship label Jun 27, 2025

fix test error

911d2f6

koji marked this pull request as ready for review June 27, 2025 05:23

koji requested a review from a team as a code owner June 27, 2025 05:23

jerader reviewed Jun 27, 2025

View reviewed changes

...src/organisms/ODD/QuickTransferFlow/QuickTransferAdvancedSettings/__tests__/Blowout.test.tsx Outdated Show resolved Hide resolved

jerader reviewed Jun 27, 2025

View reviewed changes

remove unused line

abcd599

koji commented Jun 27, 2025

View reviewed changes

app/src/organisms/ODD/QuickTransferFlow/types.ts Outdated Show resolved Hide resolved

koji requested a review from jerader July 1, 2025 01:56

koji and others added 3 commits July 2, 2025 19:19

use the same method for max flowRate

1770d02

fix test errors

0ccdd44

remove console.log()

95dccc8

ncdiehl11 reviewed Jul 7, 2025

View reviewed changes

koji added 3 commits July 7, 2025 14:05

Merge branch 'edge' into feat_add-third-step-to-blowout

8c28584

address feedback change speed to flowRate

2941823

address feedback create a new util function

931f3b5

koji requested a review from ncdiehl11 July 7, 2025 19:02

ncdiehl11 approved these changes Jul 7, 2025

View reviewed changes

fix test errors

9eff8a5

koji merged commit fe37979 into edge Jul 7, 2025
48 of 50 checks passed

koji deleted the feat_add-third-step-to-blowout branch July 7, 2025 21:50

		@@ -31,18 +31,21 @@ export function useDispenseSettingsConfig({
		const { makeSnackbar } = useToaster()

		const getBlowoutValueCopy = (): string \| undefined => {

feat(app) add third step to blowout #18760

feat(app) add third step to blowout #18760

Uh oh!

Conversation

koji commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

Uh oh!

codecov bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ncdiehl11 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

koji commented Jun 26, 2025 •

edited

Loading

codecov bot commented Jun 27, 2025 •

edited

Loading