refactor(shared-data, protocol-designer, app): Update moveToWell
command copy
#18776
+24
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes AUTH-1777
Overview
Updates the
moveToWell
command text so the run log is a bit less ambiguous about command output.It appears that the
offset
andorigin
are always provided for this command, based on looking at a few files in the engine stemming from here.NOTE: I had to revert 9e96e01 given the extensive (74) type errors that would need fixing, and I don't have the time to address them right now. I'll leave a TODO and just default to any empty string for now. It should be sufficient if these values are always present and makes this change pretty much riskless, which seems nice given where we are in the QA process.
Current Behavior
Fixed Behavior
Test Plan and Hands on Testing
Changelog
moveToWellCommand
.Risk assessment
low, just copy. Only risk comes from the assumption that we always have access to these params, but at worst we just show some undefined copy values.