Skip to content

TEMP - Testing instructions #5909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dmerand
Copy link
Contributor

@dmerand dmerand commented May 28, 2025

DO NOT merge: this branch is just testing instructions for the downstack PR.

Copy link
Contributor Author

dmerand commented May 28, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Unused files (2)

packages/app/manual-test-error-visibility.ts, packages/app/test-bundling-error-example.ts

Copy link
Contributor

github-actions bot commented May 28, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.37% (+0.35% 🔼)
12575/16046
🟡 Branches
72.59% (+0.36% 🔼)
6132/8447
🟡 Functions
78.49% (+0.21% 🔼)
3280/4179
🟡 Lines
78.81% (+0.36% 🔼)
11900/15100
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / provision_shop_access.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app.test-data.ts
92.04% (-0.46% 🔻)
93.75%
82.56% (-0.97% 🔻)
91.44% (-0.49% 🔻)
🔴
... / theme.ts
52.27% (-1.89% 🔻)
20% (-15.71% 🔻)
50%
54.76% (-2.06% 🔻)
🔴
... / dev.ts
11.57% (-7.09% 🔻)
12.33% (-1.37% 🔻)
12.12% (-12.88% 🔻)
12.39% (-6.81% 🔻)
🟢
... / fetch.ts
83.33% (-1.11% 🔻)
83.33% (+8.33% 🔼)
75% (-2.78% 🔻)
83.87% (-1.13% 🔻)
🟢
... / handlers.ts
91.94% (-5.36% 🔻)
67.86% (+1.19% 🔼)
89.47% (-10.53% 🔻)
91.8% (-5.42% 🔻)
🟢
... / Dev.tsx
92.94%
76.79% (-1.79% 🔻)
90.91% 93.75%
🔴
... / partners-client.ts
25.79% (-0.36% 🔻)
30% (-1.58% 🔻)
18.03% (+1.08% 🔼)
25.49% (-0.36% 🔻)
🟢
... / git.ts
91.92% (+0.91% 🔼)
88% (-1.36% 🔻)
90.48% (+1% 🔼)
92.71% (+0.75% 🔼)
🔴
... / rest-api-throttler.ts
38.6% (-23.77% 🔻)
50%
20% (-26.67% 🔻)
38.6% (-23.77% 🔻)
🟢
... / pull.ts
96.3% (-0.13% 🔻)
69.7% 100%
96.15% (-0.14% 🔻)
🟢
... / theme-fs.ts
81.14% (-1.42% 🔻)
63.27% (-2.69% 🔻)
71.43% (-1.49% 🔻)
83.54% (-1.03% 🔻)
🟡
... / ExtensionServerProvider.tsx
66.67% (-19.05% 🔻)
0%
46.15% (-30.77% 🔻)
68.75% (-25% 🔻)

Test suite run success

2918 tests passing in 1262 suites.

Report generated by 🧪jest coverage report action from 9c455db

@dmerand dmerand force-pushed the dlm-fix-bundling-errors-test-instructions branch from 8687fb4 to d504f78 Compare May 29, 2025 16:05
@dmerand dmerand force-pushed the dlm-fix-bundling-errors branch from c32ba32 to cd41af8 Compare May 29, 2025 16:05
EvilGenius13 and others added 21 commits June 2, 2025 11:37
update dev docs links for package command
Bumps the babel group with 1 update in the / directory: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core).
Bumps the babel group with 1 update in the /packages/eslint-plugin-cli directory: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core).


Updates `@babel/core` from 7.27.1 to 7.27.4
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.27.4/packages/babel-core)

Updates `@babel/core` from 7.27.1 to 7.27.4
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.27.4/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-version: 7.27.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: babel
- dependency-name: "@babel/core"
  dependency-version: 7.27.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: babel
...

Signed-off-by: dependabot[bot] <support@github.com>
…201169320

Bump the babel group across 2 directories with 1 update
Bumps the esbuild group with 1 update in the / directory: [esbuild](https://github.com/evanw/esbuild).
Bumps the esbuild group with 1 update in the /packages/app directory: [esbuild](https://github.com/evanw/esbuild).
Bumps the esbuild group with 1 update in the /packages/cli directory: [esbuild](https://github.com/evanw/esbuild).
Bumps the esbuild group with 1 update in the /packages/create-app directory: [esbuild](https://github.com/evanw/esbuild).


Updates `esbuild` from 0.25.4 to 0.25.5
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.25.4...v0.25.5)

Updates `esbuild` from 0.25.4 to 0.25.5
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.25.4...v0.25.5)

Updates `esbuild` from 0.25.4 to 0.25.5
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.25.4...v0.25.5)

Updates `esbuild` from 0.25.4 to 0.25.5
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md)
- [Commits](evanw/esbuild@v0.25.4...v0.25.5)

---
updated-dependencies:
- dependency-name: esbuild
  dependency-version: 0.25.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: esbuild
- dependency-name: esbuild
  dependency-version: 0.25.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: esbuild
- dependency-name: esbuild
  dependency-version: 0.25.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: esbuild
- dependency-name: esbuild
  dependency-version: 0.25.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: esbuild
...

Signed-off-by: dependabot[bot] <support@github.com>
…-9cbb25e241

Bump the esbuild group across 4 directories with 1 update
Add BP mutation to ensure access to a dev store + Ensure user access to selected dev stores
Refactor store fetch, remove dead code
…d-admins

Provision user access to stores only when permitted
graygilmore and others added 25 commits June 18, 2025 16:34
Use example for missing store help text
Implement alternative approach where items without groups ('Other') always appear at the very end, regardless of groupOrder specification. This provides better UX as users expect the fallback 'Other' category to be last.

Changes:
- Update SelectInput sorting logic to use MAX_SAFE_INTEGER + 1 for ungrouped items
- Add comprehensive test demonstrating the new behavior
- Update existing test snapshots to reflect the improved ordering

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Move comment position
Add sort order to generate extensions list
Fix `_shopify_essential` issues related to data replication and unstable connections
added error handling for authorization when backend server may not be reachable
…nt variable

This change ensures that the SHOPIFY_FLAG_ENVIRONMENT environment variable is correctly
parsed and used when passed as an environment variable.
Handle SHOPIFY_FLAG_ENVIRONMENT correctly when passed as an environment variable
Do not require authentication for app function build
[Feature] Display UI Extension Logs from Extensibility Host
…g_module_loading_by_default

Use improved config module loading by default
Add /listings folder to theme package command
Add validation to prevent app-specific webhooks and legacy install flow
Remove the encryption certificate content validation from the CLI Schema
Copy link
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.