Add support for deploy without build #5943
Conversation
This comment has been minimized.
This comment has been minimized.
|
/snapit |
Coverage report
Show files with reduced coverage 🔻
Test suite run success2875 tests passing in 1253 suites. Report generated by 🧪jest coverage report action from f293a1f |
|
🫰✨ Thanks @shauns! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g @shopify/cli@0.0.0-snapshot-20250604163132Tip If you get an Caution After installing, validate the version by running just |
shauns
force-pushed
the
shauns/06-04-add_support_for_deploy_without_build
branch
from
6495280 to
d56d98a
Compare
shauns
force-pushed
the
shauns/06-04-add_support_for_deploy_without_build
branch
from
d56d98a to
f293a1f
Compare
| }) | ||
| }) | ||
|
|
||
| test('skips building extensions if skipBuild is true', async () => { |
There was a problem hiding this comment.
I'm missing an expectation here to check that it doesn't build, no? Also, it's just copying files around, couldn't we avoid mocks?
I'd also add tests to check the special behavior for functions and theme extensions.
| await writeFile(this.outputPath, '(()=>{})();') | ||
| const mode = this.buildMode(options) | ||
|
|
||
| switch (mode) { |
| outputDebug(`Converting WASM ${this.outputPath} to base64`) | ||
| const base64Contents = await readFile(this.outputPath, {encoding: 'base64'}) | ||
| await writeFile(this.outputPath, base64Contents) |
There was a problem hiding this comment.
Could we extract this to bundleFunctionExtension? I guess we are doing the same in other place
Add
--no-buildflag toshopify app deploycommand. We've had feedback that some advanced workflows would benefit from being able to skip the build step.--
WHY are these changes introduced?
This PR adds a new flag to the
shopify app deploycommand that allows users to skip the build step during deployment, which can be useful in CI/CD pipelines where builds are performed separately.WHAT is this pull request doing?
--no-buildflag to theshopify app deploycommandcopyIntoBundlemethod to copy pre-built files instead of rebuilding thembuildModemethod for determining the build typeHow to test your changes?
shopify app build. Use a vast range of extension types.shopify app deploy --no-buildMeasuring impact
How do we know this change was effective? Please choose one:
Checklist