Add pre/post up/down support for rooted GoBackend #23
Conversation
msfjarvis
left a comment
msfjarvis
left a comment
There was a problem hiding this comment.
Jason will decide whether or not this will be merged, but I've done a preliminary review regardless.
tunnel/src/main/java/com/wireguard/android/backend/RootTunnelActionHandler.java
Outdated
Show resolved
Hide resolved
When using the GoBackend on a rooted device allow for pre/post up/down actions to be executed when the tunnel state changes. On non-rooted devices the scripts are not executed but will still be parsed from the configuration file. %i syntax is not supported. If any script fails to execute the remaining scripts in that step are skipped Signed-off-by: Adam Irr <adam.irr@outlook.com>
adamirr
force-pushed
the
up-down-actions
branch
from
cac5e07 to
baa0b4a
Compare
|
We're looking at the possibility of allowing wg-quick to control GoBackend tunnels as well, once we're able to know if that's doable we'll revisit this. |
Thanks for the update. Would this be something beyond the existing |
Yes it's going to be different. We're currently evaluating if the infrastructure we've built for remote control apps can be leveraged by |
| for (final String script : preUp) | ||
| sb.append("PreUp = ").append(script).append('\n'); | ||
| for (final String script : postUp) | ||
| sb.append("PostUp = ").append(script).append('\n'); | ||
| for (final String script : preDown) | ||
| sb.append("PreDown = ").append(script).append('\n'); | ||
| for (final String script : postDown) | ||
| sb.append("PostDown = ").append(script).append('\n'); |
There was a problem hiding this comment.
This fails since Android's wg-quick implementation doesn't support these actions. I have some changes pending that add support there as well but I'll wait to send that patch until the outcome of the potential redesign is completed.
zx2c4-bot
force-pushed
the
master
branch
3 times, most recently
from
d6a2d70 to
20390d6
Compare
zx2c4-bot
force-pushed
the
master
branch
2 times, most recently
from
8f17635 to
0750c29
Compare
|
@msfjarvis Are there still any major blockers on this? Will it be merged at some point? Or is this a dead PR? |
zx2c4-bot
force-pushed
the
master
branch
4 times, most recently
from
581ab92 to
ec126a9
Compare
zx2c4-bot
force-pushed
the
master
branch
4 times, most recently
from
c3f6e71 to
b2568c4
Compare
zx2c4-bot
force-pushed
the
master
branch
11 times, most recently
from
c046706 to
40eaa54
Compare
zx2c4-bot
force-pushed
the
master
branch
4 times, most recently
from
827495b to
4ba8794
Compare
zx2c4-bot
force-pushed
the
master
branch
4 times, most recently
from
c1d59a2 to
6aab7cc
Compare
|
Closing this since the inclination is to not merge it in the current state. |
5 participants
When using the GoBackend on a rooted device allow for pre/post up/down
actions to be executed when the tunnel state changes. On non-rooted
devices the scripts are not executed but will still be parsed from the
configuration file. %i syntax is not supported. If any script fails to
execute the remaining scripts in that step are skipped
This is part of my efforts to make my AndroidTV device (Nvidia Shield) support the traditional WireGuard server options. I tested the GoBackend on my rooted Nvidia Shield and the scripts were executed. The changes the the wg-quick script are untested as I do not have access to a device with the kernel module installed.
I am unsure of the expected behavior of any failing scripts in the pre/post up/down section of the configs. As currently implemented, a failure results in the rest of the scripts not running. If other WireGuard implementations have a different behavior, I am happy to make this match the existing behavior.
I didn't implement the
%ifunctionality since it is unclear to me if there is a standard interface name for Android's VPNs (it istun0on my Pixel3 and my Nvidia shield). If this is the standard name i can do the%ireplacement. Using the normaltunnelNamefrom the code doesn't work since that name comes from the WG config's name which doesn't match the actual interface name on Android.