Expose isAlwaysOn and isLockdownEnabled #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon-T
commented
May 23, 2025
Brandon-T
commented
- Expose isAlwaysOn and isLockdownEnabled from: https://developer.android.com/reference/android/net/VpnService
Signed-off-by: Brandon T <JustBrandonT@gmail.com>
|
Motivation? |
Hi, sorry for the late reply. I didn't see the github notification :o I'm adding a kill-switch to an app, so would need to know if lock-down is enabled. If the service isn't running, I would block all connections going out. Also would be nice to use to display a warning to the user if it's off. |
|
It would be so cool to have this merged 😍 |
msfjarvis
requested changes
Sep 19, 2025
| */ | ||
| @Override | ||
| public boolean isAlwaysOn() { | ||
| return vpnService.get(0, TimeUnit.NANOSECONDS).isAlwaysOn(); |
There was a problem hiding this comment.
Are we sure this can never race with setStateInternal? We should probably have a slightly longer timeout if that's possible.
|
Cherry-picked as afab622 with some build fixes, if there aren't any disagreements this should hit the master branch in the next 2 weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.