Added title support for the menu #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and additional sub-title
And an optional sub-title
Default value of menu_subtitle to "", so its optional
|
@ladyada I know bumping is not really a nice thing to do for a PR.. but... (small) bump :) |
|
hiya we had to refactor this library. can you show me what the new menus look like, a picture? |
|
can u have just one function for menus, you can add the menutitle at the end of the param list, so it defaults to something (rather than 2 nearly identical functions) |
|
Just ordered the PyGamer, will fix this as soon as I can after receiving the package :) |
Removed double check for touchscreen-to-button LEFT button
I tested the added title and sub-title support! In the previous commit, the menu-items weren't moved down enough (x-axis) Will upload photos (or EXTREME-awesome-paint-pro images) to the PR
|
|
|
ok will review this next time we're working on this library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added another menu-method with support for a title and sub-title
Using this method instead of the other will remove the "hint" at the bottom of the menu.
I created this method as a first step to simplify the file-selection menu
(which contains code that needs to be in another .cpp file, like Adafruit_Arcada_Alerts.cpp).