-
Notifications
You must be signed in to change notification settings - Fork 54
Add SH1107 for 128x64/32 OLED featherwings #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@brentru this is ready for review |
Is this happening currently? Will this stop happening in a few hours? Days? I don't want to modify the build script to get something passing immediately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tyeth I'm requesting some changes as it's the first PR you've done against the displays. I also have some questions
src/components/i2c/drivers/WipperSnapper_I2C_Driver_Out_Ssd1306.h
Outdated
Show resolved
Hide resolved
src/components/i2c/drivers/WipperSnapper_I2C_Driver_Out_Ssd1306.h
Outdated
Show resolved
Hide resolved
src/components/i2c/drivers/WipperSnapper_I2C_Driver_Out_Ssd1306.h
Outdated
Show resolved
Hide resolved
src/components/i2c/drivers/WipperSnapper_I2C_Driver_Out_Ssd1306.h
Outdated
Show resolved
Hide resolved
src/components/i2c/drivers/WipperSnapper_I2C_Driver_Out_Ssd1306.h
Outdated
Show resolved
Hide resolved
src/components/i2c/drivers/WipperSnapper_I2C_Driver_Out_Sh1107.h
Outdated
Show resolved
Hide resolved
@brentru this should be good now. The components PR is updated too: adafruit/Wippersnapper_Components#263 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you for making the requested changes.
This ties in with adafruit/Wippersnapper_Components#263
The build task was modified to allow single board builds, due to circuitpython hogging the build agents.
The SH1107 is added, for the featherwing. It uses the width as height and height as width in the learn guide example, then relying on rotation = 1. I've had to include this to make the board usable in the interface, but it now begs the question of whether we add rotation to the protobuf, and as a degrees decimal, or possibly just 0-3.
Multiple SSD1306 options are added to support extra displays/components, and the library args to no longer call i2c begin.