Skip to content

Conversation

tyeth
Copy link
Member

@tyeth tyeth commented Jun 19, 2025

This ties in with adafruit/Wippersnapper_Components#263

The build task was modified to allow single board builds, due to circuitpython hogging the build agents.

The SH1107 is added, for the featherwing. It uses the width as height and height as width in the learn guide example, then relying on rotation = 1. I've had to include this to make the board usable in the interface, but it now begs the question of whether we add rotation to the protobuf, and as a degrees decimal, or possibly just 0-3.

Multiple SSD1306 options are added to support extra displays/components, and the library args to no longer call i2c begin.

@tyeth tyeth marked this pull request as ready for review July 8, 2025 18:24
@tyeth
Copy link
Member Author

tyeth commented Jul 8, 2025

@brentru this is ready for review

@tyeth tyeth requested a review from brentru July 8, 2025 18:34
@brentru
Copy link
Member

brentru commented Jul 8, 2025

@tyeth

The build task was modified to allow single board builds, due to circuitpython hogging the build agents.

Is this happening currently? Will this stop happening in a few hours? Days? I don't want to modify the build script to get something passing immediately.

@tyeth
Copy link
Member Author

tyeth commented Jul 8, 2025

@tyeth

The build task was modified to allow single board builds, due to circuitpython hogging the build agents.

Is this happening currently? Will this stop happening in a few hours? Days? I don't want to modify the build script to get something passing immediately.

No, it is an optional box when the job is used via workflow dispatch manually from the actions page. It does the same behaviour as before.

If you goto that page, the CI job, then choose branch sh1107, you see the extra box Screenshot_20250708-201229.png

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyeth I'm requesting some changes as it's the first PR you've done against the displays. I also have some questions

@tyeth tyeth requested a review from brentru July 9, 2025 16:45
@tyeth
Copy link
Member Author

tyeth commented Jul 9, 2025

@brentru this should be good now. The components PR is updated too: adafruit/Wippersnapper_Components#263

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for making the requested changes.

@tyeth tyeth merged commit 13bfecf into main Jul 9, 2025
37 checks passed
@tyeth tyeth deleted the sh1107 branch July 9, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants