fix(@angular/build): set scripts option output as classic script for karma #30535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…karma When using the `karma` builder, the generated output JavaScript file was unintentionally being marked as a module type script. This prevent the output file from providing equivalent behavior to that of an actual build. The `scripts` option outputs should be considered classic scripts to the browser.
jkrems
approved these changes
Jun 13, 2025
|
The changes were merged into the following branches: main, 20.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
karmabuilder, the generated output JavaScript file was unintentionally being marked as a module type script. This prevent the output file from providing equivalent behavior to that of an actual build. Thescriptsoption outputs should be considered classic scripts to the browser.Closes #30534